HDDS-15839. Implement SCM container ID export manager#10813
Open
sarvekshayr wants to merge 5 commits into
Open
HDDS-15839. Implement SCM container ID export manager#10813sarvekshayr wants to merge 5 commits into
sarvekshayr wants to merge 5 commits into
Conversation
devmadhuu
reviewed
Jul 20, 2026
devmadhuu
left a comment
devmadhuu
left a comment
Contributor
There was a problem hiding this comment.
Thanks @sarvekshayr for the patch. Largely the PR looks good, just few minor comments.
szetszwo
reviewed
Jul 21, 2026
Contributor
There was a problem hiding this comment.
@sarvekshayr , thanks for splitting this out. Some general comments
- Refactor out all the File/Directory related code to a new class ExportFileManager
- Describe directory layout in ExportFileManager (very important since changing it is an incompatible change)
- Except for ContainerExportManager, use "Export" instead of "ContainerExport" as the prefix for the classnames
See also the comments inlined.
Contributor
@sarvekshayr , indeed, this PR is also quite big. Let's work on ExportFileManager and directory layout in a separated JIRA. |
Contributor
Author
Created HDDS-15935. |
devmadhuu
reviewed
Jul 22, 2026
devmadhuu
left a comment
devmadhuu
left a comment
Contributor
There was a problem hiding this comment.
Thanks @sarvekshayr for improving the patch. Largely LGTM +1. Just a nit for rare case. Pls check.
sarvekshayr
marked this pull request as ready for review
July 22, 2026 17:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Adds the SCM leader-side container ID export worker. Jobs paginate through
ContainerManager.getContainerIDs()with lifecycle/health filters, write sharded text files, and pack them into a TAR.ContainerExportLimits.java- Shared page/shard defaults and capsContainerExportStatus.java- Job status snapshot (State, filters, row count, TAR path, error)ContainerExportManager.java- Async export worker: submit, paginate, shard, TAR append, job trackingContainerExportMetrics.java- Export job counters and last-success gaugesTestContainerExportManager.java- Unit tests with mocked ContainerManagerPart 3 of 5 in splitting HDDS-15496 #10673 container ID export.
What is the link to the Apache JIRA
HDDS-15839
How was this patch tested?
Added a new unit test class
TestContainerExportManager(no RPC or CLI yet).CI: https://github.com/sarvekshayr/ozone/actions/runs/29718653670