fix: replace misleading 504 with 408 on timeout page (#41544)#41817
fix: replace misleading 504 with 408 on timeout page (#41544)#41817xiyaoeva wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThis PR updates error message constants for server timeout scenarios. The HTTP status code for timeout errors changed from ChangesHTTP 408 Error Message Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description
Fixes #41544
Summary
This PR fixes a misleading timeout error page code shown to users.
What changed
504to408.Request timed out.The server is taking too long to respond. Please retry after some time.Why
504indicates a gateway/proxy timeout, which is misleading for client-side request timeout scenarios.408better matches the intended timeout semantics shown on the UI.Dependencies
Testing
messages.ts:PAGE_SERVER_TIMEOUT_ERROR_CODE = "408"PAGE_SERVER_TIMEOUT_TITLE = "Request timed out"PAGE_SERVER_TIMEOUT_DESCRIPTION = "The server is taking too long to respond. Please retry after some time"Automation
/ok-to-test tags=""
🔍 Cypress test results
Caution
If you modify the content in this section, you are likely to disrupt the CI result for your PR.
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit