Skip to content

fix: replace misleading 504 with 408 on timeout page (#41544)#41817

Open
xiyaoeva wants to merge 1 commit into
appsmithorg:releasefrom
xiyaoeva:fix/41544-misleading-timeout-error-code
Open

fix: replace misleading 504 with 408 on timeout page (#41544)#41817
xiyaoeva wants to merge 1 commit into
appsmithorg:releasefrom
xiyaoeva:fix/41544-misleading-timeout-error-code

Conversation

@xiyaoeva
Copy link
Copy Markdown

@xiyaoeva xiyaoeva commented May 14, 2026

Description

Fixes #41544

Summary

This PR fixes a misleading timeout error page code shown to users.

What changed

  • Updated timeout error code from 504 to 408.
  • Updated timeout title to Request timed out.
  • Updated timeout description to:
    The server is taking too long to respond. Please retry after some time.

Why

504 indicates a gateway/proxy timeout, which is misleading for client-side request timeout scenarios.
408 better matches the intended timeout semantics shown on the UI.

Dependencies

  • None

Testing

  • Code-level validation completed in messages.ts:
    • PAGE_SERVER_TIMEOUT_ERROR_CODE = "408"
    • PAGE_SERVER_TIMEOUT_TITLE = "Request timed out"
    • PAGE_SERVER_TIMEOUT_DESCRIPTION = "The server is taking too long to respond. Please retry after some time"

Automation

/ok-to-test tags=""

🔍 Cypress test results

Caution

If you modify the content in this section, you are likely to disrupt the CI result for your PR.

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • Bug Fixes
    • Enhanced error messaging for request timeouts. When requests exceed the maximum allowed processing time, users now receive clearer, more informative error messages paired with specific retry guidance. This update improves the user experience by helping users quickly understand what went wrong and take appropriate action to recover from timeout situations.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 14, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: fcd5957c-7598-4c25-81a4-4f7b5eb5939f

📥 Commits

Reviewing files that changed from the base of the PR and between d75495a and 7ad0765.

📒 Files selected for processing (1)
  • app/client/src/ce/constants/messages.ts

Walkthrough

This PR updates error message constants for server timeout scenarios. The HTTP status code for timeout errors changed from 504 (Gateway Timeout) to 408 (Request Timeout), accompanied by revised title and description text to provide clearer retry guidance to users.

Changes

HTTP 408 Error Message Update

Layer / File(s) Summary
Server timeout error message constants
app/client/src/ce/constants/messages.ts
Error page constants updated to use HTTP 408 instead of 504, with new title "Request timed out" and improved retry guidance in the description.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

⏳ A timeout awaits, no longer 504—
Now 408 knocks upon the door.
"Request timed out," the message reads clear,
Guiding users back without their fear. 🔄

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The PR is linked to issue #41544 about signup registration settings, but the actual changes only modify timeout error messages in messages.ts with no code changes addressing the signup visibility bug. Verify the correct issue is linked. The PR should address signup settings visibility, not timeout error codes. Either link to the correct timeout-related issue or add code changes that resolve the signup registration bug.
Out of Scope Changes check ⚠️ Warning Changes to timeout error messages (code 504→408, title, description) are completely unrelated to the linked issue about signup registration settings visibility. Either link this PR to a timeout-related issue or include code changes that address the signup settings bug described in #41544.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: replacing HTTP error code 504 with 408 on the timeout error page, directly matching the code modifications.
Description check ✅ Passed The PR description follows the template structure with issue link, summary, changelog, rationale, dependencies, testing details, and communication checkbox. All required sections are present and complete.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Allowing only invited users to register is not working

1 participant