Skip to content

fix: replace misleading 504 with 408 on timeout page (#41544) #41817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xiyaoeva wants to merge 1 commit into
base: release
Choose a base branch
from
+3 −3
Open

fix: replace misleading 504 with 408 on timeout page (#41544) #41817

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions app/client/src/ce/constants/messages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,11 +487,11 @@ export const BACK_TO_HOMEPAGE = () => "Go back to homepage";
// error pages
export const PAGE_NOT_FOUND_TITLE = () => "404";
export const PAGE_NOT_FOUND = () => "Page not found";
export const PAGE_SERVER_TIMEOUT_ERROR_CODE = () => "504";
export const PAGE_SERVER_TIMEOUT_ERROR_CODE = () => "408";
export const PAGE_SERVER_TIMEOUT_TITLE = () =>
"Appsmith server is taking too long to respond";
"Request timed out";
export const PAGE_SERVER_TIMEOUT_DESCRIPTION = () =>
`Please retry after some time`;
`The server is taking too long to respond. Please retry after some time`;
export const PAGE_CLIENT_ERROR_TITLE = () => "Whoops something went wrong!";
export const PAGE_CLIENT_ERROR_DESCRIPTION = () =>
"This is embarrassing, please contact Appsmith support for help";
Expand Down