fix(AF-566): open API request detail from the API Reviews queue#575
Merged
Conversation
The API Reviews queue offered only blind Approve/Reject buttons — a
reviewer had no way to inspect the request before deciding. Rows now
navigate to /api-requests/{id} on click (same pattern as the SQL
review queue); the decision buttons stop propagation so they still
open the comment modal in place. Covered by a new Playwright spec.
Contributor
Frontend Test Results1 133 tests 1 133 ✅ 2m 53s ⏱️ Results for commit ebcd224. |
Contributor
Coverage Report for Frontend Coverage (frontend)
File CoverageNo changed files found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Reviewers had no way to view an API request from the API Reviews page — the queue offered only blind Approve/Reject buttons. Rows on
/api-reviewsare now clickable and navigate to the request detail page (/api-requests/{id}), where the reviewer sees the full request context (verb, path, justification, AI summary/risk, decisions) plus the inline Approve/Reject decision block.Why
Follow-up to #571 (AF-566), which fixed the backend so non-admin reviewers can fetch any API request detail — but the frontend never got the navigation affordance, so the detail page remained unreachable from the review queue.
How
ApiReviewQueuePage: added anonRowclick handler (pointer cursor) navigating to the detail page, mirroring the SQLReviewQueuePagepattern. The Approve/Reject buttons now calle.stopPropagation()so they keep opening the decision modal in place without triggering navigation.e2e/tests/api-request-review.spec.ts: a reviewer opens/api-reviews, clicks a pending row, lands on/api-requests/{id}, and sees the Approve/Reject block.Verification
eslint+tsc -b --noEmitclean on the frontend.docker-compose.e2e.yml):api-request-review.spec.ts3/3 passed (including the new spec), and theapi-governancefilter-bar spec (the other consumer of/api-reviews) still passes.Note:
cd e2e && npm run typecheckfails on cleanmainwith a pre-existing null-safety error inquery-list.spec.ts— unrelated to this change, will be fixed separately.