Abstract functionality to allow open sourcing under ros-sports#1
Open
texhnolyze wants to merge 5 commits into
Open
Abstract functionality to allow open sourcing under ros-sports#1texhnolyze wants to merge 5 commits into
texhnolyze wants to merge 5 commits into
Conversation
texhnolyze
force-pushed
the
feature/abstract-for-open-source
branch
2 times, most recently
from
16aa652 to
7e40cab
Compare
Member
|
I find it relatively hard to see what was changed compared to the version we are currently playing with. As the version on this repo is much older. I need some more time to review this in this case. Also it seems like some API changed. Do we want to integrate it with our software during this world cup to test it or do we want to do it afterwards? |
6 tasks
MegaIng
approved these changes
Jul 1, 2026
both from the game controller and the player response. Keep as close to the original [protocol], but add additional utility fields where it makes sense. [protocol]: https://github.com/RoboCup-HumanoidSoccerLeague/GameController/blob/master/game_controller_msgs/headers/RoboCupGameControlData.h BREAKING CHANGE: as some field types/names changed this needs adoption
and also update and adapt fields in the game_controller protocol, while introducing additional `GameState` utility fields
to allow additional functionalities like yellow/red cards
texhnolyze
force-pushed
the
feature/abstract-for-open-source
branch
from
7e40cab to
ad7cf26
Compare
texhnolyze
added a commit
to bit-bots/bitbots_main
that referenced
this pull request
Jul 1, 2026
after properly setting up a PlayerStateResponse in bit-bots/game_controller_hsl#1 This makes the architecture much cleaner as we do not have dependencies to `game_controller_hsl` in multiple components, which could also function without any game controller.
BloodWork44
pushed a commit
to bit-bots/bitbots_main
that referenced
this pull request
Jul 2, 2026
after properly setting up a PlayerStateResponse in bit-bots/game_controller_hsl#1 This makes the architecture much cleaner as we do not have dependencies to `game_controller_hsl` in multiple components, which could also function without any game controller.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does the following:
PlayerStateResponsemsg with sensible ROS defaults, meaning teams do not have to do unit conversions or publishing in multiple components. This also allows us at the bit-bots to not have to publish from HCM, Localization, etc. but a generalized component