[PM-37255] feat: Wire fill-assist manager into vault sync and app startup#6992
[PM-37255] feat: Wire fill-assist manager into vault sync and app startup#6992aj-rosado wants to merge 2 commits into
Conversation
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE This PR wires the existing Code Review DetailsNo findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## PM-37255/fill-assist-data-layer #6992 +/- ##
====================================================================
+ Coverage 69.18% 86.19% +17.00%
====================================================================
Files 878 878
Lines 63557 64003 +446
Branches 9245 9272 +27
====================================================================
+ Hits 43974 55168 +11194
+ Misses 16792 5636 -11156
- Partials 2791 3199 +408
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-37255
📔 Objective
Connects the fill-assist manager to the rest of the app so rules are fetched and kept fresh automatically.
Changes:
VaultSyncManagerImpl— callsfillAssistManager.syncIfNecessary()after vault data is stored; fill-assist failures are silently dropped and never affect vault syncVaultManagerModule— injectsFillAssistManagerintoVaultSyncManagerBitwardenApplication— injectsFillAssistManagerto trigger eager initialization; theinit {}block subscribes toserverConfigStateFlowfor config-change-triggered syncs