Bug 889650: Fix crash when searching "match all of the same field" on Flags - #179
Open
topunix wants to merge 1 commit into
Open
Bug 889650: Fix crash when searching "match all of the same field" on Flags#179topunix wants to merge 1 commit into
topunix wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Harmony port of bugzilla/bugzilla#237. The grouped flag search in
_flagtypes_nonchanged was reading from $bugs_table, which has already been
reassigned to the grouped alias at that point, so the subquery referenced a
bugs_g2 table that does not exist. Reads from the real bugs table instead.
Also adds the matching regression test to CUSTOM_SEARCH_TESTS.
Additional info