Skip to content

Bug 889650: Fix crash when searching "match all of the same field" on Flags #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
topunix wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bug 889650: Fix crash when searching "match all of the same field" on Flags #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Bugzilla/Search.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3219,7 +3219,7 @@ sub _flagtypes_nonchanged {
# don't call build_subselect as this must run as a true sub-select
$args->{term} = "EXISTS (
SELECT 1
FROM $bugs_table bugs_$chart_id
FROM bugs bugs_$chart_id
LEFT JOIN attachments AS attachments_$chart_id
ON bugs_$chart_id.bug_id = attachments_$chart_id.bug_id
LEFT JOIN flags AS flags_$chart_id
Expand Down
9 changes: 9 additions & 0 deletions xt/lib/Bugzilla/Test/Search/Constants.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1257,6 +1257,15 @@ use constant CUSTOM_SEARCH_TESTS => (
]
},

{
name => 'flagtypes.name = <1> AND flagtypes.name = <1>',
contains => [1],
top_params => {j_top => 'AND_G'},
params => [
{f => 'flagtypes.name', o => 'equals', v => '<1>'},
{f => 'flagtypes.name', o => 'equals', v => '<1>'},
]
},
);

1;