acc: test more zero-valued fields in pipeline#5462
Merged
Conversation
Mirrors the photon-false test to verify that serverless: false is sent by the direct engine but silently dropped by the terraform engine (the Terraform provider does not add Serverless to ForceSendFields). Both tests now also capture .databricks/bundle/default/terraform/bundle.tf.json when it exists, confirming the CLI correctly writes the false value into the Terraform config — the loss happens in the provider, not the CLI. Co-authored-by: Denis Bilenko <denis.bilenko@databricks.com>
Collaborator
|
Commit: ff508de
22 interesting tests: 15 SKIP, 7 RECOVERED
Top 25 slowest tests (at least 2 minutes):
|
Merge the photon-false and serverless-false pipeline tests into a single zero-value-fields test that sets photon, serverless, continuous and development all to false. The terraform engine drops all of them while the direct engine sends them; bundle.tf.json shows the CLI writes them correctly, so the loss is in the Terraform provider. Co-authored-by: Denis Bilenko <denis.bilenko@databricks.com>
denik
changed the title
pietern
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend #5434 (
photon-false) withserverless: falseandcontinous: falseThe test now also dump
bundle.tf.jsonwhen present, showing the CLI writes thefalsevalue correctly — it is the Terraform provider that drops it.