Skip to content

acceptance: add zero-value-fields pipeline test #5462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
denik merged 2 commits into from
Jun 8, 2026
Merged

acceptance: add zero-value-fields pipeline test #5462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8c26e0
acceptance: add serverless-false pipeline test and show tf json proof
denik Jun 7, 2026
ff508de
acceptance: consolidate photon/serverless into zero-value-fields test
denik Jun 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions acceptance/bundle/resources/pipelines/photon-false/script
View file
Open in desktop

This file was deleted.

7 changes: 0 additions & 7 deletions acceptance/bundle/resources/pipelines/photon-false/test.toml
View file
Open in desktop

This file was deleted.

5 changes: 4 additions & 1 deletion ...ces/pipelines/photon-false/databricks.yml → ...ipelines/zero-value-fields/databricks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,14 @@
bundle:
name: photon-false
name: zero-value-fields

resources:
pipelines:
my:
name: test-pipeline
photon: false
serverless: false
continuous: false
development: false
libraries:
- file:
path: "./foo.py"
0 ...e/resources/pipelines/photon-false/foo.py → ...ources/pipelines/zero-value-fields/foo.py
View file
Open in desktop
File renamed without changes.
9 changes: 6 additions & 3 deletions ...ines/photon-false/out.requests.direct.txt → ...zero-value-fields/out.requests.direct.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,19 +3,22 @@
"path": "/api/2.0/pipelines",
"body": {
"channel": "CURRENT",
"continuous": false,
"deployment": {
"kind": "BUNDLE",
"metadata_file_path": "/Workspace/Users/[USERNAME]/.bundle/photon-false/default/state/metadata.json"
"metadata_file_path": "/Workspace/Users/[USERNAME]/.bundle/zero-value-fields/default/state/metadata.json"
},
"development": false,
"edition": "ADVANCED",
"libraries": [
{
"file": {
"path": "/Workspace/Users/[USERNAME]/.bundle/photon-false/default/files/foo.py"
"path": "/Workspace/Users/[USERNAME]/.bundle/zero-value-fields/default/files/foo.py"
}
}
],
"name": "test-pipeline",
"photon": false
"photon": false,
"serverless": false
}
}
4 changes: 2 additions & 2 deletions ...s/photon-false/out.requests.terraform.txt → ...o-value-fields/out.requests.terraform.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,13 @@
"channel": "CURRENT",
"deployment": {
"kind": "BUNDLE",
"metadata_file_path": "/Workspace/Users/[USERNAME]/.bundle/photon-false/default/state/metadata.json"
"metadata_file_path": "/Workspace/Users/[USERNAME]/.bundle/zero-value-fields/default/state/metadata.json"
},
"edition": "ADVANCED",
"libraries": [
{
"file": {
"path": "/Workspace/Users/[USERNAME]/.bundle/photon-false/default/files/foo.py"
"path": "/Workspace/Users/[USERNAME]/.bundle/zero-value-fields/default/files/foo.py"
}
}
],
Expand Down
0 ...rces/pipelines/photon-false/out.test.toml → ...pipelines/zero-value-fields/out.test.toml
View file
Open in desktop
File renamed without changes.
22 changes: 22 additions & 0 deletions acceptance/bundle/resources/pipelines/zero-value-fields/out.tf.terraform.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
{
"my": {
"channel": "CURRENT",
"continuous": false,
"deployment": {
"kind": "BUNDLE",
"metadata_file_path": "/Workspace/Users/[USERNAME]/.bundle/zero-value-fields/default/state/metadata.json"
},
"development": false,
"edition": "ADVANCED",
"library": [
{
"file": {
"path": "/Workspace/Users/[USERNAME]/.bundle/zero-value-fields/default/files/foo.py"
}
}
],
"name": "test-pipeline",
"photon": false,
"serverless": false
}
}
2 changes: 1 addition & 1 deletion ...sources/pipelines/photon-false/output.txt → ...es/pipelines/zero-value-fields/output.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

>>> [CLI] bundle deploy
Uploading bundle files to /Workspace/Users/[USERNAME]/.bundle/photon-false/default/files...
Uploading bundle files to /Workspace/Users/[USERNAME]/.bundle/zero-value-fields/default/files...
Deploying resources...
Updating deployment state...
Deployment complete!
6 changes: 6 additions & 0 deletions acceptance/bundle/resources/pipelines/zero-value-fields/script
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
trace $CLI bundle deploy
print_requests.py //api/2.0/pipelines > out.requests.$DATABRICKS_BUNDLE_ENGINE.txt 2>&1

if [ -f .databricks/bundle/default/terraform/bundle.tf.json ]; then
jq .resource.databricks_pipeline .databricks/bundle/default/terraform/bundle.tf.json > out.tf.$DATABRICKS_BUNDLE_ENGINE.json
fi
7 changes: 7 additions & 0 deletions acceptance/bundle/resources/pipelines/zero-value-fields/test.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Badness = "zero-value bool fields (photon, serverless, continuous, development) are not sent in the terraform deployment"
Local = true
Cloud = false
RecordRequests = true

[EnvMatrix]
DATABRICKS_BUNDLE_ENGINE = ["terraform", "direct"]
Loading