added validation_config.json#1996
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new validation configuration file, validation_config.json, for the World Bank WDI dataset. It defines rules for checking deleted record counts and performing golden file comparisons. The review feedback highlights path inconsistencies for golden files and a missing directory prefix for input files, which could prevent the validation tool from locating the necessary data.
|
@gemini-code-assist review |
There was a problem hiding this comment.
Code Review
This pull request introduces import validation for the World Bank WDI dataset by adding a validation configuration, updating the manifest, and providing golden data files. Feedback includes a missing file reference for 'golden_WorldBank.csv', a path mismatch for the summary report, and a suggestion to move golden files to a local directory for better self-containment. Additionally, the documentation header in the README should be generalized to describe the process rather than the PR, and the threshold for the deleted records percentage may need adjustment to reflect the intended strictness.
2 participants
No description provided.