Skip to content

Fix vswhere -requires switch for where/run workload filters#267

Merged
kzu merged 1 commit into
mainfrom
dev/where
Jul 10, 2026
Merged

Fix vswhere -requires switch for where/run workload filters#267
kzu merged 1 commit into
mainfrom
dev/where

Conversation

@kzu

@kzu kzu commented Jul 10, 2026

Copy link
Copy Markdown
Member

Summary

  • Restore single-dash -requires when forwarding workload filters to vswhere from where and run (double-dash --requires is rejected as unknown).
  • Keep installer paths on --add / --remove.
  • Skip null args when building the vswhere process argument list; add unit tests for both switch styles.

Test plan

  • vs where +native returns matching instances
  • vs where --requires Microsoft.VisualStudio.Workload.NativeDesktop works
  • vs where +native --prop InstallationPath works
  • WorkloadOptions unit tests pass

Pass single-dash -requires to vswhere (not --requires), which rejects double-dash switches. Installer commands keep --add/--remove.
@kzu kzu added the bug Something isn't working label Jul 10, 2026
@kzu kzu enabled auto-merge (rebase) July 10, 2026 00:11
@kzu

kzu commented Jul 10, 2026

Copy link
Copy Markdown
Member Author

180 passed 180 passed

🧪 Details on Microsoft Windows 10.0.26100

from retest v1.1.0 on .NET 10.0.9 with 💜 by @devlooped

@kzu kzu merged commit dce002d into main Jul 10, 2026
4 checks passed
@kzu kzu deleted the dev/where branch July 10, 2026 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant