Skip to content

Fix COM wrapper weak-handle defensive copy in ReferenceTrackerNativeObjectWrapper #129668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 3 commits into
base: main
Choose a base branch
from
+1 −1
Open

Fix COM wrapper weak-handle defensive copy in ReferenceTrackerNativeObjectWrapper #129668

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d144cf5
Initial plan
Copilot Jun 21, 2026
3fca0c4
Fix defensive-copy risk for ComWrappers weak handle
Copilot Jun 21, 2026
b42d42a
Add ComWrappers weak-handle comment
Copilot Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libraries/System.Private.CoreLib/src/System/Runtime/InteropServices/ComWrappers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -669,7 +669,7 @@ internal sealed class ReferenceTrackerNativeObjectWrapper : NativeObjectWrapper
internal readonly IntPtr _contextToken;
private int _trackerObjectDisconnected; // Atomic boolean, so using int.
private readonly bool _releaseTrackerObject;
internal readonly GCHandle _nativeObjectWrapperWeakHandle;
internal GCHandle _nativeObjectWrapperWeakHandle; // mutable struct; do not make this readonly

public IntPtr TrackerObject => (_trackerObject == IntPtr.Zero || _trackerObjectDisconnected == 1) ? IntPtr.Zero : _trackerObject;

Expand Down