R8a: remove the dead Theme setting (finding #9) - #175
Merged
Conversation
Settings' General page had a Theme select (Dark/Muted/Monochromatic) that persisted a real setTheme intent, but nothing in the SPA ever applied the value: no data-theme attribute, no alternate --gl-surface-* token set, the app rendered identically regardless of selection. Per user decision, removed rather than wired up - building two real alternate palettes is a design investment, not a bug fix, and a persisted preference that provably does nothing is worse than no preference. Removed end to end: the frontend select and its options, the setTheme intent and its handler, get_theme/set_theme on SettingsManager (including the now-pointless in-memory backfill for legacy state files missing the key), the theme field from the app-settings wire contract (regenerated), and the now-stale "Appearance" Help entry that described this exact control. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Settings' General page had a Theme select (Dark/Muted/Monochromatic) that persisted a real
setThemeintent, but nothing in the SPA ever applied the value — nodata-themeattribute, no alternate token set, the app rendered identically regardless of selection.Change
Removed rather than wired up, per product decision: building two real alternate palettes is a design investment (new
--gl-surface-*token sets need real color choices), not a mechanical fix, and a persisted preference that provably does nothing is worse than no preference.Removed end to end:
SettingsDialog.tsx).setThemeintent and its handler (backend/settings.py).get_theme/set_themeonSettingsManager, including the now-pointless in-memory backfill for legacy state files missing the key (graphlink_licensing.py).themefield from theapp-settingswire contract, with the generated TS/JSON artifacts regenerated (contracts/graphlink_app_settings_payload.py).help-data/sections.ts).Test plan
npx tsc --noEmitnpx vitest run(full suite)python -m pytest -q(full suite)npm run check:schemanpm run lint/npm run buildLive-verified against a running instance: Settings > General now opens directly to "Show Token Counter Overlay" with no Theme control, and the Notification-types checkboxes still round-trip correctly.