R8a: remove the dead Theme setting (finding #9)

backend/settings.py

@@ -349,7 +349,6 @@ def _llama_cpp_scan_summary(manager: SettingsManager) -> str:
 
 def settings_payload(manager: SettingsManager) -> dict[str, Any]:
     return {
-        "theme": manager.get_theme(),
         "showTokenCounter": manager.get_show_token_counter(),
         "enableSystemPrompt": manager.get_enable_system_prompt(),
         "notificationPreferences": manager.get_notification_preferences(),
@@ -482,10 +481,6 @@ async def set_active_section(section: str):
     # are GIL-atomic, and every mutation republishes on completion, so a
     # snapshot that races a write is immediately superseded by a settled one.
 
-    async def set_theme(theme: str):
-        await asyncio.to_thread(_apply, manager.set_theme, str(theme))
-        await bus.publish("app-settings")
-
     async def set_show_token_counter(enabled: bool):
         await asyncio.to_thread(_apply, manager.set_show_token_counter, bool(enabled))
         await bus.publish("app-settings")
@@ -1236,7 +1231,6 @@ def _persist() -> None:
         await bus.publish("app-settings")
 
     bus.register_intent("app-settings", "setActiveSection", set_active_section)
-    bus.register_intent("app-settings", "setTheme", set_theme)
     bus.register_intent("app-settings", "setShowTokenCounter", set_show_token_counter)
     bus.register_intent("app-settings", "setEnableSystemPrompt", set_enable_system_prompt)
     bus.register_intent("app-settings", "setNotificationPreference", set_notification_preference)

backend/tests/test_settings.py

@@ -32,7 +32,6 @@ async def send_json(self, data):
 def test_settings_payload_shape_matches_generated_validator_shape(manager):
     payload = settings_payload(manager)
     assert set(payload) == {
-        "theme",
         "showTokenCounter",
         "enableSystemPrompt",
         "notificationPreferences",
@@ -42,7 +41,6 @@ def test_settings_payload_shape_matches_generated_validator_shape(manager):
 
 def test_settings_payload_reflects_real_manager_defaults(manager):
     payload = settings_payload(manager)
-    assert payload["theme"] == "dark"
     # R8a: the token counter overlay is off by default - opt-in, not opt-out.
     assert payload["showTokenCounter"] is False
     assert payload["enableSystemPrompt"] is True
@@ -80,7 +78,6 @@ def test_register_settings_publishes_active_section_alongside_manager_state(mana
     asyncio.run(bus.publish("app-settings"))
     payload = recorder.messages[0]["payload"]
     assert payload["activeSection"] == "general"
-    assert payload["theme"] == "dark"
 
 
 def test_set_active_section_intent_updates_only_local_ui_state(manager):
@@ -94,18 +91,6 @@ def test_set_active_section_intent_updates_only_local_ui_state(manager):
     assert payload["activeSection"] == "integrations"
 
 
-def test_set_theme_intent_persists_to_the_real_settings_manager(manager):
-    bus = SessionBus("settings-theme-test")
-    register_settings(bus, manager)
-
-    asyncio.run(bus.dispatch_intent("app-settings", "setTheme", ["light"]))
-    assert manager.get_theme() == "light"
-    # A fresh manager reading the same file proves it was actually persisted,
-    # not just mutated in memory.
-    reloaded = SettingsManager(manager.state_file)
-    assert reloaded.get_theme() == "light"
-
-
 def test_set_show_token_counter_intent(manager):
     bus = SessionBus("settings-token-counter-test")
     register_settings(bus, manager)
@@ -178,17 +163,17 @@ def test_an_old_settings_file_without_schema_version_is_backfilled(tmp_path):
     import json
 
     state_file = tmp_path / "session.dat"
-    state_file.write_text(json.dumps({"theme": "mono"}), encoding="utf-8")
+    state_file.write_text(json.dumps({"show_token_counter": True}), encoding="utf-8")
 
     old_manager = SettingsManager(state_file)
 
     # Backfilled in memory immediately, the same as every other pre-existing
-    # key here (theme, show_token_counter, ...) - none of those write back to
-    # disk until the next explicit set_*() call either, so schema_version
+    # key here (show_token_counter, ...) - none of those write back to disk
+    # until the next explicit set_*() call either, so schema_version
     # matching that existing pattern is correct, not a gap.
     assert old_manager.get_schema_version() == SettingsManager.CURRENT_SCHEMA_VERSION
 
-    old_manager.set_theme("mono")  # any setter call persists the whole (now-backfilled) state
+    old_manager.set_show_token_counter(False)  # any setter call persists the whole (now-backfilled) state
     assert json.loads(state_file.read_text(encoding="utf-8"))["schema_version"] == SettingsManager.CURRENT_SCHEMA_VERSION
 
 

contracts/graphlink_app_settings_payload.py

@@ -35,7 +35,6 @@ class AppSettingsStatePayload:
     schemaVersion: int
     revision: int
     activeSection: str
-    theme: str
     showTokenCounter: bool
     enableSystemPrompt: bool
     notificationPreferences: dict[str, bool]

graphlink_licensing.py

@@ -85,8 +85,6 @@ def _load_state(self):
         try:
             with open(self.state_file, 'r') as f:
                 state = json.load(f)
-                if 'theme' not in state:
-                    state['theme'] = 'dark'
                 if 'show_token_counter' not in state:
                     state['show_token_counter'] = False
                 state_changed = False
@@ -232,7 +230,6 @@ def _backup_corrupt_state_file(self, error):
     def _create_initial_state(self):
         state = {
             "schema_version": self.CURRENT_SCHEMA_VERSION,
-            "theme": "dark",
             "show_token_counter": False,
             "ollama_chat_model": "",
             "ollama_title_model": "",
@@ -370,13 +367,6 @@ def _save_state(self, state_data=None):
     def get_schema_version(self):
         return self.state.get("schema_version", self.CURRENT_SCHEMA_VERSION)
 
-    def get_theme(self):
-        return self.state.get("theme", "dark")
-
-    def set_theme(self, theme_name):
-        self.state['theme'] = theme_name
-        self._save_state()
-
     def get_show_token_counter(self):
         # R8a: off by default - the overlay is opt-in now, not opt-out.
         return self.state.get("show_token_counter", False)

web_ui/src/app/chrome/SettingsDialog.test.tsx

@@ -17,7 +17,6 @@ const snapshot = {
   minCompatibleSchemaVersion: 1,
   revision: 1,
   activeSection: "general",
-  theme: "dark",
   showTokenCounter: true,
   enableSystemPrompt: true,
   notificationPreferences: { info: true, success: true, warning: true, error: true },

web_ui/src/app/chrome/SettingsDialog.tsx

@@ -49,12 +49,6 @@ function basename(path: string): string {
   return path.split(/[\\/]/).pop() || path;
 }
 
-const THEME_OPTIONS = [
-  { value: "dark", label: "Dark" },
-  { value: "muted", label: "Muted" },
-  { value: "mono", label: "Monochromatic" },
-];
-
 const NOTIFICATION_TYPE_LABELS: Record<string, string> = {
   info: "Info",
   success: "Success",
@@ -95,7 +89,6 @@ const initialState: AppSettingsState = {
   minCompatibleSchemaVersion: 1,
   revision: 0,
   activeSection: "General",
-  theme: "dark",
   showTokenCounter: true,
   enableSystemPrompt: true,
   notificationPreferences: {},
@@ -146,23 +139,15 @@ function GeneralPage({
   state: AppSettingsState;
   transport: WsTransport;
 }) {
+  // R8a (UI/UX issue list finding #9): a Theme select (Dark/Muted/
+  // Monochromatic) used to live here. It persisted a real setTheme intent,
+  // but nothing in the SPA ever applied the value - no data-theme attribute,
+  // no alternate token set, the app rendered identically no matter what was
+  // selected. Removed rather than wired up: building two real alternate
+  // palettes is a design decision, not a bug fix, and a persisted preference
+  // that provably does nothing is worse than no preference at all.
   return (
     <div className="settings-general-page">
-      <label className="settings-field">
-        <span className="settings-field-label">Theme</span>
-        <select
-          className="settings-select"
-          value={state.theme}
-          onChange={(event) => transport.intent("app-settings", "setTheme", [event.target.value])}
-        >
-          {THEME_OPTIONS.map(({ value, label }) => (
-            <option key={value} value={value}>
-              {label}
-            </option>
-          ))}
-        </select>
-      </label>
-
       <label className="settings-checkbox-row">
         <input
           type="checkbox"

web_ui/src/app/chrome/help-data/sections.ts

@@ -361,10 +361,6 @@ export const HELP_SECTIONS: HelpSection[] = [
       {
         "title": "Personalization and Feedback",
         "items": [
-          {
-            "action": "Appearance",
-            "description": "Theme and appearance settings restyle the app, including flyouts and node accents, around the current palette. This is mainly cosmetic, but it helps tailor the workspace to your preference."
-          },
           {
             "action": "Token Counter",
             "description": "When enabled, the token counter shows prompt, context, output, and running session totals. It is useful when you want a sense of branch size or model budget."

web_ui/src/lib/bridge-core/generated/app-settings-state.schema.json

@@ -165,9 +165,6 @@
     "showTokenCounter": {
       "type": "boolean"
     },
-    "theme": {
-      "type": "string"
-    },
     "viewingApiProvider": {
       "type": "string"
     }
@@ -176,7 +173,6 @@
     "schemaVersion",
     "revision",
     "activeSection",
-    "theme",
     "showTokenCounter",
     "enableSystemPrompt",
     "notificationPreferences",

web_ui/src/lib/bridge-core/generated/app-settings-state.ts

@@ -14,7 +14,6 @@ export interface AppSettingsState {
   schemaVersion: number;
   revision: number;
   activeSection: string;
-  theme: string;
   showTokenCounter: boolean;
   enableSystemPrompt: boolean;
   notificationPreferences: Record<string, boolean>;
@@ -113,11 +112,6 @@ function checkAppSettingsState(value: unknown, path: string, errors: string[]):
     if (fieldValue === undefined || fieldValue === null) errors.push(`${path}.activeSection: missing required field`);
     else { if (typeof fieldValue !== "string") errors.push(`${path}.activeSection` + ": expected string"); }
   }
-  {
-    const fieldValue = value["theme"];
-    if (fieldValue === undefined || fieldValue === null) errors.push(`${path}.theme: missing required field`);
-    else { if (typeof fieldValue !== "string") errors.push(`${path}.theme` + ": expected string"); }
-  }
   {
     const fieldValue = value["showTokenCounter"];
     if (fieldValue === undefined || fieldValue === null) errors.push(`${path}.showTokenCounter: missing required field`);