[POC] feat: add proxy-sovd crate with SOVD REST client and UDS <->SOVD mapper by arvindr19 · Pull Request #12 · eclipse-opensovd/uds2sovd-proxy

arvindr19 · 2026-04-22T08:04:32Z

Summary

Adds the proxy-sovd crate: SOVD gateway HTTP client, UDS <-> SOVD JSON translation, and the SovdDiagHandler implementation.

Depends on: PR #11 (proxy-core)

Changes

SovdClient: OAuth2 auth, GET /data/{service} reads, PUT /configurations/{service} writes, mock gateway mode for offline testing, MDD-driven mock response generation
SovdMapper: Translates RDBI/WDBI UDS requests into SOVD REST calls and encodes JSON responses back to UDS bytes via MDD metadata
SovdDiagHandler: Concrete struct with inherent pub async fn handle_read_did / handle_write_did — wires ServiceResolver + SovdMapper for end-to-end UDS processing.
DataResponse: SOVD response schema (mirrors sovd_interfaces::ObjectDataItem with Deserialize)

Scope

Read (0x22) and Write (0x2E) services only. Mock gateway enabled by default.

Checklist

I have tested my changes locally
I have added or updated documentation
I have linked related issues or discussions
I have added or updated tests

Notes for Reviewers

Since this part of stacked PR, you could see changes from #11 , until it gets merged
Review required for proxy-sovd crate

…nd workspace setup Signed-off-by: Arvind Rathod <Arvind.RA.Rathod@bti.bmwgroup.com>

Signed-off-by: Arvind Rathod <Arvind.RA.Rathod@bti.bmwgroup.com>

lh-sag · 2026-04-23T09:46:38Z

@arvindr19 did you took a look at the client in core? https://github.com/eclipse-opensovd/opensovd-core/tree/inc/liebherr/opensovd-client

If

Signed-off-by: Arvind Rathod <Arvind.RA.Rathod@bti.bmwgroup.com>

arvindr19 · 2026-04-27T06:46:58Z

@arvindr19 did you took a look at the client in core? https://github.com/eclipse-opensovd/opensovd-core/tree/inc/liebherr/opensovd-client

If

Hi @lh-sag , I briefly glanced over the SOVD client repo, it might be useful in the future.

As of now, the goal is to parse UDS requests using the MDD request/response structure and generate a mocked response. The REST API request is just a placeholder for now. I think the proxy might need something like the SOVD client, or we could potentially reuse it here.

Signed-off-by: Arvind Rathod <Arvind.RA.Rathod@bti.bmwgroup.com>

bharatGoswami8 · 2026-04-28T06:57:14Z

+                    .json()
+                    .await
+                    .map_err(|e| SovdError::Http(e.to_string()))?;
+                info!("[SOVD] Response: HTTP 200 OK");


how about moving this log before data parsing.

bharatGoswami8 · 2026-04-28T07:32:12Z

+                if p.name.contains('/') {
+                    if let Some(prefix) = &mux_case_prefix {
+                        if !p.name.starts_with(prefix.as_str()) {
+                            return false;
+                        }
+                    } else {
+                        return false;
+                    }
+                }


Suggested change

if p.name.contains('/') {

if let Some(prefix) = &mux_case_prefix {

if !p.name.starts_with(prefix.as_str()) {

return false;

}

} else {

return false;

}

}

if p.name.contains('/') {

match &mux_case_prefix {

Some(prefix) if name.starts_with(prefix.as_str()) => {}

_ => return false,

}

}

bharatGoswami8 · 2026-04-28T07:33:02Z

+                continue;
+            }
+            // Skip params from non-matching MUX cases.
+            if p.name.contains('/') {


same here like above mentioned.

bharatGoswami8 · 2026-04-28T07:47:49Z

+        if self.config.mock_gateway {
+            let token = "mock-access-token".to_string();
+            *self.access_token.write().await = Some(token.clone());
+            info!("[SOVD] Mock authentication enabled");


you are using tracing::Info in service provider and here you directly using , please keep consistency

yes, using tracing

bharatGoswami8

@arvindr19
I’ve reviewed proxy-sovd and added some comments and suggestions.
In my opinion, we should ensure tracing is used consistently across the entire codebase

Signed-off-by: Arvind Rathod <Arvind.RA.Rathod@bti.bmwgroup.com>

rpreddyhv · 2026-04-28T09:30:04Z

+            .process_write_data_request(did, uds_request, &service_name, parsed_data)
+            .await
+    }
+}


question: don't we need tests in this file?

handle_read_did/write_did require ServiceResolver backed by a CDA EcuManager and an mdd file laoded on disk, there's no way mock for now.

bharatGoswami8 · 2026-04-28T10:00:37Z

+    ///
+    /// # Errors
+    /// Returns an error if the read request fails.
+    pub async fn read_data(&self, component: &str, data_id: &str) -> Result<DataResponse> {


What if user interchange str value in input to component and data_id, can we use newType here.

The call sites are both internal, always passing &self.config.ecu.default_name as the component and service_name.to_lowercase() as the data_id a swap would be immediately obvious at runtime error. Adding newtypes is just boilerplate

bharatGoswami8 · 2026-04-28T10:01:06Z

+        &self,
+        component: &str,
+        data_id: &str,
+        data: serde_json::Map<String, Value>,


What if user interchange str value in input to component and data_id, can we use newType here.

same as above.

Signed-off-by: Arvind Rathod <Arvind.RA.Rathod@bti.bmwgroup.com>

tejaswinijoshi89 · 2026-04-29T08:45:20Z

+        self.ecu_managers.get(ecu_name).or_else(|| {
+            warn!(
+                "[ECU] Default ECU '{}' not found, falling back to first available",
+                ecu_name


why to use the first available ecu. in case ecu name is not found, can we return none?

Removed fallback, return None if ECU name not found

tejaswinijoshi89 · 2026-04-29T08:47:20Z

+///   write requests that need request-parameter context.
+pub struct SovdMapper {
+    /// Proxy configuration (ECU, SOVD endpoint, mock settings).
+    config: Config,


config is already stored in sovddiaghandler. why 2nd copy is maintained here?

Updated, Extract only 4 needed fields at construction time (ecu_name, mock_gateway, gateway_url, api_version)

tejaswinijoshi89 · 2026-04-29T08:54:00Z

+
+    fn ecu_manager(&self) -> Option<&ServiceResolver> {
+        let ecu_name = &self.config.ecu.default_name;
+        self.ecu_managers.get(ecu_name).or_else(|| {


why so you need ecu_managers as map when you want to get serviceResolver for your own ECU
If it is for any future requirement extension better to mention in comment

added comment

tejaswinijoshi89 · 2026-04-29T10:21:14Z

+            .ecu_manager()
+            .ok_or_else(|| ProxyError::Mdd("No MDD database loaded".to_string()))?;
+
+        let ResolvedService {


USD service resolution, processing received data request and forming the response for specific request can be done in more clean way considering extendable solution approach. I understand, this is not current focus of the implementation but consider design approach where different UDS services can be implemented independently without impacting the existing source code, may be command pattern would help here, one command per serivce

agree that we need something like this. but will plan it in future PRs

tejaswinijoshi89 · 2026-04-29T10:23:07Z

+
+//! Core types and traits shared across all proxy crates.
+//!
+//! Defines configuration, error types, the [`DiagHandler`] trait for


where is DiagHandler trait?

It was part of initial changes, removed later. Updated comment

tejaswinijoshi89 · 2026-04-29T10:59:02Z

+                        .or_else(|| response_data.get(short_name))
+                        .or_else(|| response_data.get(&param.name.to_ascii_lowercase()))
+                        .or_else(|| response_data.get(&short_name.to_ascii_lowercase()))
+                        .or_else(|| response_data.get("data"));


why hardcoded to "data"

The data fallback is a legitimate SOVD protocol detail: when a service returns a single scalar value, the SOVD ObjectDataItem stores it under the key data regardless of the MDD parameter name. Without this fallback, any response whose MDD param name doesn't match any key in the SOVD JSON would encode as zeroes. The constant replaces the magic string with a named, documented symbol, it doesn't change behaviour.

tejaswinijoshi89 · 2026-04-29T11:53:17Z

+    /// Returns `None` when no metadata is available. On success returns the
+    /// encoded bytes and the effective service name (which may differ when
+    /// enriched MUX sibling metadata is used).
+    async fn encode_response_from_metadata(


This is very huge function, please try to split it in to meaning full smaller functions. Also some part of the code looks repetitive line 210 to 245 (client.rs 270)

generate_mock_response_data() from client.rs will be removed once sovd-server provides real responses

Please split this function into meaningful smaller funtions

tejaswinijoshi89 · 2026-04-29T11:58:10Z

+        &self,
+        sid: u8,
+        did: u16,
+        _uds_bytes: &[u8],


does _uds_bytes really needed in future, if not remove

tejaswinijoshi89 · 2026-04-29T11:59:59Z

+ * https://www.apache.org/licenses/LICENSE-2.0
+ */
+
+use std::{collections::HashMap, sync::Arc};


Here HashMap is used from collections where as at other places its used from cda_interfaces. No functional change but better to keep consistency with same set of interfaces unless their is any valid reason behind using it differently

updated, using cda_interfaces

tejaswinijoshi89 · 2026-04-29T12:08:18Z

+impl Default for SovdConfig {
+    fn default() -> Self {
+        Self {
+            gateway_url: "http://localhost:20002".to_string(),


Instead of adding magic values/strings directly, add it as const or macros

added const for config fields

Signed-off-by: Arvind Rathod <Arvind.RA.Rathod@bti.bmwgroup.com>

…thods

Signed-off-by: Arvind Rathod <Arvind.RA.Rathod@bti.bmwgroup.com>

arvindr19 added 2 commits April 22, 2026 09:31

feat: add proxy-core crate with shared types, MDD service resolver, a…

d7f2fc1

…nd workspace setup Signed-off-by: Arvind Rathod <Arvind.RA.Rathod@bti.bmwgroup.com>

PR1: Add proxy-core to workspace members

a5837f9

arvindr19 requested a review from a team as a code owner April 22, 2026 08:04

arvindr19 marked this pull request as draft April 22, 2026 08:04

arvindr19 mentioned this pull request Apr 22, 2026

[POC] feat: add proxy-main binary, FLXC1000 test client #14

Open

4 tasks

arvindr19 added 2 commits April 22, 2026 11:11

Restore comments and original structure to Cargo.toml and deny.toml

da5fa2c

fix: remove unused Serialize & parse_response fct

4af1e6a

Signed-off-by: Arvind Rathod <Arvind.RA.Rathod@bti.bmwgroup.com>

fix: review comments & split service_resolver

b0c39a0

Signed-off-by: Arvind Rathod <Arvind.RA.Rathod@bti.bmwgroup.com>

refactor: remove DiagHandler trait from proxy-core

b1ef0eb

Signed-off-by: Arvind Rathod <Arvind.RA.Rathod@bti.bmwgroup.com>

arvindr19 force-pushed the feat/proxy-sovd branch 2 times, most recently from d018b37 to b230075 Compare April 27, 2026 09:52

arvindr19 marked this pull request as ready for review April 27, 2026 10:23

arvindr19 force-pushed the feat/proxy-sovd branch from b230075 to ee9c5c4 Compare April 27, 2026 10:25

Fix: Addresss review comments

06c5c41

Signed-off-by: Arvind Rathod <Arvind.RA.Rathod@bti.bmwgroup.com>

arvindr19 force-pushed the feat/proxy-sovd branch 2 times, most recently from 5cf6e04 to 4c373b4 Compare April 28, 2026 06:48

bharatGoswami8 reviewed Apr 28, 2026

View reviewed changes

Fix: svg images fixed

7d6e2bf

Signed-off-by: Arvind Rathod <Arvind.RA.Rathod@bti.bmwgroup.com>

rpreddyhv reviewed Apr 28, 2026

View reviewed changes

bharatGoswami8 reviewed Apr 28, 2026

View reviewed changes

Refactoe: service_resolver mod into subcompoents

edf6c99

Signed-off-by: Arvind Rathod <Arvind.RA.Rathod@bti.bmwgroup.com>

arvindr19 mentioned this pull request Apr 29, 2026

[POC] feat: add proxy-core crate with shared types, MDD service resolver, and workspace setup #11

Open

4 tasks

arvindr19 force-pushed the feat/proxy-sovd branch from 4c373b4 to 891dcb0 Compare April 29, 2026 07:18

tejaswinijoshi89 reviewed Apr 29, 2026

View reviewed changes

Fix: address review comments

a3b2e13

Signed-off-by: Arvind Rathod <Arvind.RA.Rathod@bti.bmwgroup.com>

arvindr19 force-pushed the feat/proxy-sovd branch from a4ba199 to d00c17f Compare April 30, 2026 12:27

fix: parsing cli, used clap and url crate

629276e

arvindr19 force-pushed the feat/proxy-sovd branch from d00c17f to c24a3d2 Compare May 7, 2026 10:31

arvindr19 changed the title ~~feat: add proxy-sovd crate with SOVD REST client and UDS <->SOVD mapper~~ [POC] feat: add proxy-sovd crate with SOVD REST client and UDS <->SOVD mapper May 11, 2026

arvindr19 added 10 commits May 12, 2026 14:06

refactor: encapsulate ServiceResolver internals behind facade methods

246dfb8

refactor: address review comments for service_parsing

9ee9c55

feat: add proxy-sovd crate with SOVD REST client and UDS<->SOVD mapper

fbdf246

Signed-off-by: Arvind Rathod <Arvind.RA.Rathod@bti.bmwgroup.com>

fix: update diag_handler to use ResolvedService struct

e129131

refactor: remove async_trait, convert DiagHandler impl to inherent me…

f0060db

…thods

Fix: self review

6beac40

Signed-off-by: Arvind Rathod <Arvind.RA.Rathod@bti.bmwgroup.com>

Fix: address review comments

1853c0c

Signed-off-by: Arvind Rathod <Arvind.RA.Rathod@bti.bmwgroup.com>

refactor: address review comments for proxy-sovd

2eabdfc

fix: address review comments for proxy-sovd

6d56e00

fix: address review comments for proxy-sovd

d6a04c6

Signed-off-by: Arvind Rathod <Arvind.RA.Rathod@bti.bmwgroup.com>

arvindr19 force-pushed the feat/proxy-sovd branch from c24a3d2 to d6a04c6 Compare May 12, 2026 12:28

Conversation

arvindr19 commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Scope

Checklist

Related

Notes for Reviewers

Uh oh!

lh-sag commented Apr 23, 2026

Uh oh!

arvindr19 commented Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bharatGoswami8 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

arvindr19 commented Apr 22, 2026 •

edited

Loading

arvindr19 commented Apr 27, 2026 •

edited

Loading