[POC] feat: add proxy-core crate with shared types, MDD service resolver, and workspace setup#11

Open

arvindr19 wants to merge 12 commits into

eclipse-opensovd:mainfrom

arvindr19:service_parsing

Contributor

arvindr19 commented Apr 22, 2026 •

edited

Loading

Summary

Restructures the repository into a Cargo workspace and introduces the proxy-core foundation crate.

Changes

Workspace migration: Converts the single-crate layout to a multi-crate workspace with proxy-core, proxy-doip, proxy-sovd, proxy-main members (follow up PRs [POC] feat: add proxy-sovd crate with SOVD REST client and UDS <->SOVD mapper #12 , [POC] feat: add proxy-doip crate — DoIP transport layer (temporary, RDBI/WDBI only) #13 & [POC] feat: add proxy-main binary, FLXC1000 test client #14 ). CDA dependencies pinned to eclipse-opensovd/classic-diagnostic-adapter@cf7fd9c1.
proxy-core:
- Config / ServerConfig / SovdConfig / EcuConfig --> TOML-driven configuration
- ProxyError / UdsError / SovdError / Nrc --> structured error hierarchy with ISO 14229-1 NRC codes
- ServiceResolver exposes three composable components:
  1. DidResolver - DID-to-service resolution
    - Resolves DID values to MDD service names using prefix matching
    - Returns ResolvedService with matched service name and decoded request parameters
    - resolve_read_service() / resolve_write_service() methods for READ/WRITE services
    - Integrates with CDA's EcuManager for MDD lookups
  2. ResponseEncoder - UDS response encoding
    - Encodes MDD service responses into raw UDS bytes
    - Handles CodedConst, PhysConst, and Value parameter types
    - MUX-aware encoding for multiplexed services
  3. MetadataProvider - MDD parameter metadata queries
    - Exposes service parameter metadata from the MDD
    - Enables inspection of parameter types, ranges, and encoding rules without resolving requests
  Implementation Details
  - resolve.rs - DID resolution logic with prefix lookup and request parameter extraction
  - response.rs - Response encoding with support for computed/physical/value parameters
  - metadata.rs - Parameter metadata queries and inspection
  - uds_helpers.rs - Low-level UDS byte manipulation and matching utilities
config.toml: Default proxy configuration
testcontainer/mdd/FLXC1000.mdd: Open-source sample MDD for testing

Scope

Parse and validate UDS requests and responses using MDD structures.
Current implementation covers ReadDataByIdentifier (0x22) and WriteDataByIdentifier (0x2E) services only.

Current Approach

proxy-sovd and proxy-doip act as placeholder/temporary logic providers.
proxy-sovd
- Creates dummy REST API requests and triggers mocked response generation APIs.
proxy-doip
- A minimal DoIP server that connects to the client and processes read/write services.
- Will be replaced once the full DoIP server implementation is merged and ready for use.

Checklist

I have tested my changes locally
I have added or updated documentation
I have linked related issues or discussions
I have added or updated tests

Related

Notes for Reviewers


          feat: add proxy-core crate with shared types, MDD service resolver, a…

d7f2fc1

…nd workspace setup

Signed-off-by: Arvind Rathod <Arvind.RA.Rathod@bti.bmwgroup.com>

arvindr19 requested a review from a team as a code owner

April 22, 2026 07:39


          PR1: Add proxy-core to workspace members

a5837f9

arvindr19 force-pushed the service_parsing branch from de4b24b to a5837f9 Compare

April 22, 2026 07:51

This was referenced Apr 22, 2026

[POC] feat: add proxy-doip crate — DoIP transport layer (temporary, RDBI/WDBI only) #13

Open

[POC] feat: add proxy-sovd crate with SOVD REST client and UDS <->SOVD mapper #12

Open

[POC] feat: add proxy-main binary, FLXC1000 test client #14

Open

arvindr19 force-pushed the service_parsing branch from e4f0f6d to 7117777 Compare

April 22, 2026 09:07


          Restore comments and original structure to Cargo.toml and deny.toml

da5fa2c

arvindr19 force-pushed the service_parsing branch from 7117777 to da5fa2c Compare

April 22, 2026 09:11

bharatGoswami8 reviewed

View reviewed changes

proxy-core/src/config.rs Outdated

bharatGoswami8 reviewed

View reviewed changes

proxy-core/src/config.rs

bharatGoswami8 reviewed

View reviewed changes

proxy-core/src/config.rs

bharatGoswami8 reviewed

View reviewed changes

proxy-core/src/config.rs Outdated

bharatGoswami8 reviewed

View reviewed changes

proxy-core/src/config.rs

This was referenced Apr 23, 2026

Improvement: Configuration Validation Enhancement #15

Closed

Improvement: Real Variant Detection via ECU DID Reads #16

Open

Improvement: Remove encoding fallback once SOVD server returns structured responses #17

Open

Improvement: Add support for diag services #18

Open


          fix: remove unused Serialize & parse_response fct

4af1e6a

Signed-off-by: Arvind Rathod <Arvind.RA.Rathod@bti.bmwgroup.com>

darkwisebear suggested changes

View reviewed changes

darkwisebear left a comment

The service_resolver.rs file is just too big. Please split this into smaller units and add a reference to some class diagram or the like so that I as a human being do not have to reverse engineer what it does.

proxy-core/src/config.rs Outdated

proxy-core/src/config.rs Outdated

proxy-core/src/config.rs Outdated

proxy-core/src/config.rs Outdated

proxy-core/src/diag_handler.rs Outdated

proxy-core/src/config.rs

config.toml Outdated

proxy-core/src/service_resolver.rs Outdated

arvindr19 force-pushed the service_parsing branch from 9729efb to 2b5f19b Compare

April 23, 2026 12:35


          fix: review comments & split service_resolver

b0c39a0

Signed-off-by: Arvind Rathod <Arvind.RA.Rathod@bti.bmwgroup.com>

arvindr19 force-pushed the service_parsing branch from 2b5f19b to b0c39a0 Compare

April 23, 2026 12:46

darkwisebear reviewed

View reviewed changes

darkwisebear left a comment

Haven't been able to finish the review, but there is already some material to work on.

Cargo.toml Outdated

proxy-core/src/service_resolver/mod.rs Outdated

proxy-core/src/service_resolver/mod.rs Outdated

proxy-core/src/service_resolver/mod.rs Outdated

proxy-core/src/service_resolver/mod.rs Outdated

proxy-core/src/service_resolver/resolve.rs Outdated

proxy-core/src/service_resolver/mod.rs Outdated

proxy-core/src/service_resolver/resolve.rs Outdated

proxy-core/src/service_resolver/resolve.rs Outdated

proxy-core/src/service_resolver/resolve.rs

arvindr19 force-pushed the service_parsing branch from ce1e93b to 529c1b4 Compare

April 24, 2026 12:15


          refactor: remove DiagHandler trait from proxy-core

b1ef0eb

Signed-off-by: Arvind Rathod <Arvind.RA.Rathod@bti.bmwgroup.com>

arvindr19 force-pushed the service_parsing branch from 529c1b4 to b1ef0eb Compare

April 27, 2026 09:15

arvindr19 added a commit to arvindr19/uds2sovd-proxy that referenced this pull request


          fix: address remaining PR eclipse-opensovd#11 review comments

9fb8387

- Add UdsResponse<'a> wrapper with sid()/is_negative()/nrc() accessors
- is_negative_response/get_nrc delegate to UdsResponse — no more raw byte indexing
- Add ResolvedService { name, params } struct; replace (String, Map) tuple in
  resolve_read_service / resolve_write_service return types
- Split resolve_service_did into build_did_candidates + match_candidate_did
- or_else + match pattern in activate_base_variant (replaces nested if/else)
- Add RwLock doc comment explaining write-reservation intent
- Remove redundant HashSet alongside Vec in candidate dedup
- Add #[cfg(test)] modules to resolve.rs, metadata.rs, response.rs
  (6 + 9 + 12 new unit tests; 63 total in proxy-core)

rpreddyhv reviewed

View reviewed changes

README.md Outdated

proxy-core/src/config.rs Outdated

proxy-core/src/config.rs Outdated

proxy-core/src/config.rs

proxy-core/src/error.rs

bharatGoswami8 reviewed

View reviewed changes

proxy-core/src/service_resolver/response.rs

bharatGoswami8 reviewed

View reviewed changes

proxy-core/src/service_resolver/response.rs

bharatGoswami8 reviewed

View reviewed changes

proxy-core/src/service_resolver/uds_helpers.rs Outdated

bharatGoswami8 reviewed

View reviewed changes

bharatGoswami8 left a comment

@arvindr19 , I’ve reviewed service_resolver and suggest refactoring it into feature-specific types.
For example, we could move metadata into its own type and then used as a component of the primary ServiceResolver or as a specialized internal type. This approach would significantly improve the code's modularity and structural clarity.

Also please add justification for clippy supresseion.

This was referenced Apr 28, 2026

Improvement: proxy-core - optimize config.rs while integrating doip-server changes #22

Open

Improvement: proxy-core - Refactor service_resolver #23

Open


          Fix: Addresss review comments

06c5c41

Signed-off-by: Arvind Rathod <Arvind.RA.Rathod@bti.bmwgroup.com>

Contributor Author

arvindr19 commented Apr 28, 2026

@arvindr19 , I’ve reviewed service_resolver and suggest refactoring it into feature-specific types. For example, we could move metadata into its own type and then used as a component of the primary ServiceResolver or as a specialized internal type. This approach would significantly improve the code's modularity and structural clarity.

Also please add justification for clippy supresseion.

Thank you for the review,
service_resolver neeeds a lot of refactoring. Created #23 and I'll pick it up next.
added justification for clippy attributes.


          Fix: svg images fixed

7d6e2bf

Signed-off-by: Arvind Rathod <Arvind.RA.Rathod@bti.bmwgroup.com>

arvindr19 force-pushed the service_parsing branch from bc6b669 to 7d6e2bf Compare

April 28, 2026 09:08

rpreddyhv reviewed

View reviewed changes

rpreddyhv left a comment •

edited

Loading

minor comment

proxy-core/src/error.rs


          Refactoe: service_resolver mod into subcompoents

edf6c99

Signed-off-by: Arvind Rathod <Arvind.RA.Rathod@bti.bmwgroup.com>

bharatGoswami8 reviewed

View reviewed changes

proxy-core/src/service_resolver/mod.rs Outdated

+                  /// Return a [`DidResolver`] for DID-to-service resolution.
+                  #[must_use]
+                  pub fn did_resolver(&self) -> DidResolver {

bharatGoswami8 Apr 29, 2026

do we want to give different type to user?
How about ServiceResolver will work as centralize or user consumer instance and it will maintain all this type as a private internally, so with that all the public APIs can be called with ServiceResolver instance.

Contributor Author

arvindr19 Apr 30, 2026 •

edited

Loading

updated, now ServiceResolver has 3 sub components and only necessary APIs made pub.

arvindr19 added a commit to arvindr19/uds2sovd-proxy that referenced this pull request


          fix: address remaining PR eclipse-opensovd#11 review comments

cbbf31a

- Add UdsResponse<'a> wrapper with sid()/is_negative()/nrc() accessors
- is_negative_response/get_nrc delegate to UdsResponse — no more raw byte indexing
- Add ResolvedService { name, params } struct; replace (String, Map) tuple in
  resolve_read_service / resolve_write_service return types
- Split resolve_service_did into build_did_candidates + match_candidate_did
- or_else + match pattern in activate_base_variant (replaces nested if/else)
- Add RwLock doc comment explaining write-reservation intent
- Remove redundant HashSet alongside Vec in candidate dedup
- Add #[cfg(test)] modules to resolve.rs, metadata.rs, response.rs
  (6 + 9 + 12 new unit tests; 63 total in proxy-core)


          Fix: address review comments

a3b2e13

Signed-off-by: Arvind Rathod <Arvind.RA.Rathod@bti.bmwgroup.com>

arvindr19 added a commit to arvindr19/uds2sovd-proxy that referenced this pull request


          fix: address remaining PR eclipse-opensovd#11 review comments

785df33

- Add UdsResponse<'a> wrapper with sid()/is_negative()/nrc() accessors
- is_negative_response/get_nrc delegate to UdsResponse — no more raw byte indexing
- Add ResolvedService { name, params } struct; replace (String, Map) tuple in
  resolve_read_service / resolve_write_service return types
- Split resolve_service_did into build_did_candidates + match_candidate_did
- or_else + match pattern in activate_base_variant (replaces nested if/else)
- Add RwLock doc comment explaining write-reservation intent
- Remove redundant HashSet alongside Vec in candidate dedup
- Add #[cfg(test)] modules to resolve.rs, metadata.rs, response.rs
  (6 + 9 + 12 new unit tests; 63 total in proxy-core)

bharatGoswami8 reviewed

View reviewed changes

proxy-core/src/service_resolver/mod.rs Outdated

bharatGoswami8 reviewed

View reviewed changes

proxy-core/src/service_resolver/metadata.rs

bharatGoswami8 reviewed

View reviewed changes

proxy-core/src/service_resolver/resolve.rs

bharatGoswami8 reviewed

View reviewed changes

proxy-core/src/service_resolver/resolve.rs

bharatGoswami8 reviewed

View reviewed changes

proxy-core/src/service_resolver/response.rs

arvindr19 added a commit to arvindr19/uds2sovd-proxy that referenced this pull request


          fix: address remaining PR eclipse-opensovd#11 review comments

db55da9

- Add UdsResponse<'a> wrapper with sid()/is_negative()/nrc() accessors
- is_negative_response/get_nrc delegate to UdsResponse — no more raw byte indexing
- Add ResolvedService { name, params } struct; replace (String, Map) tuple in
  resolve_read_service / resolve_write_service return types
- Split resolve_service_did into build_did_candidates + match_candidate_did
- or_else + match pattern in activate_base_variant (replaces nested if/else)
- Add RwLock doc comment explaining write-reservation intent
- Remove redundant HashSet alongside Vec in candidate dedup
- Add #[cfg(test)] modules to resolve.rs, metadata.rs, response.rs
  (6 + 9 + 12 new unit tests; 63 total in proxy-core)

alexmohr reviewed

View reviewed changes

testcontainer/mdd/FLXC1000.mdd

alexmohr May 7, 2026

question: So this is more a general question than it is with this particular change. Would it help to exrtact the testing utils, like the ECU sim, testcontainer, odx generation etc. into a separate repo cda and proxy can just use as submodule?

arvindr19 changed the title ~~feat: add proxy-core crate with shared types, MDD service resolver, and workspace setup~~ [POC] feat: add proxy-core crate with shared types, MDD service resolver, and workspace setup


          refactor: encapsulate ServiceResolver internals behind facade methods

1bcaf23

Signed-off-by: Arvind Rathod <Arvind.RA.Rathod@bti.bmwgroup.com>

arvindr19 force-pushed the service_parsing branch from 629276e to 1bcaf23 Compare

May 12, 2026 12:24

arvindr19 added a commit to arvindr19/uds2sovd-proxy that referenced this pull request


          fix: address remaining PR eclipse-opensovd#11 review comments

7a7dbf2

- Add UdsResponse<'a> wrapper with sid()/is_negative()/nrc() accessors
- is_negative_response/get_nrc delegate to UdsResponse — no more raw byte indexing
- Add ResolvedService { name, params } struct; replace (String, Map) tuple in
  resolve_read_service / resolve_write_service return types
- Split resolve_service_did into build_did_candidates + match_candidate_did
- or_else + match pattern in activate_base_variant (replaces nested if/else)
- Add RwLock doc comment explaining write-reservation intent
- Remove redundant HashSet alongside Vec in candidate dedup
- Add #[cfg(test)] modules to resolve.rs, metadata.rs, response.rs
  (6 + 9 + 12 new unit tests; 63 total in proxy-core)

arvindr19 added a commit to arvindr19/uds2sovd-proxy that referenced this pull request


          fix: address remaining PR eclipse-opensovd#11 review comments

fec3891

- Add UdsResponse<'a> wrapper with sid()/is_negative()/nrc() accessors
- is_negative_response/get_nrc delegate to UdsResponse — no more raw byte indexing
- Add ResolvedService { name, params } struct; replace (String, Map) tuple in
  resolve_read_service / resolve_write_service return types
- Split resolve_service_did into build_did_candidates + match_candidate_did
- or_else + match pattern in activate_base_variant (replaces nested if/else)
- Add RwLock doc comment explaining write-reservation intent
- Remove redundant HashSet alongside Vec in candidate dedup
- Add #[cfg(test)] modules to resolve.rs, metadata.rs, response.rs
  (6 + 9 + 12 new unit tests; 63 total in proxy-core)


          fix: address review comments for service_parsing

5750b9b

arvindr19 force-pushed the service_parsing branch from b33b7bf to 5750b9b Compare

May 12, 2026 13:11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

alexmohr alexmohr left review comments

+3 more reviewers

darkwisebear darkwisebear requested changes

rpreddyhv rpreddyhv left review comments

bharatGoswami8 bharatGoswami8 left review comments

At least 1 approving review is required to merge this pull request.

Labels

None yet