[POC] feat: add proxy-doip crate — DoIP transport layer (temporary, RDBI/WDBI only)#13
Open
arvindr19 wants to merge 33 commits into
Open
[POC] feat: add proxy-doip crate — DoIP transport layer (temporary, RDBI/WDBI only)#13arvindr19 wants to merge 33 commits into
arvindr19 wants to merge 33 commits into
Conversation
…nd workspace setup Signed-off-by: Arvind Rathod <Arvind.RA.Rathod@bti.bmwgroup.com>
arvindr19
changed the title
4 tasks
Signed-off-by: Arvind Rathod <Arvind.RA.Rathod@bti.bmwgroup.com>
Signed-off-by: Arvind Rathod <Arvind.RA.Rathod@bti.bmwgroup.com>
Signed-off-by: Arvind Rathod <Arvind.RA.Rathod@bti.bmwgroup.com>
arvindr19
force-pushed
the
feat/proxy-doip
branch
from
1a60101 to
a88c0bb
Compare
Signed-off-by: Arvind Rathod <Arvind.RA.Rathod@bti.bmwgroup.com>
Signed-off-by: Arvind Rathod <Arvind.RA.Rathod@bti.bmwgroup.com>
Signed-off-by: Arvind Rathod <Arvind.RA.Rathod@bti.bmwgroup.com>
Open
4 tasks
arvindr19
force-pushed
the
feat/proxy-doip
branch
from
a88c0bb to
5d24e48
Compare
Signed-off-by: Arvind Rathod <Arvind.RA.Rathod@bti.bmwgroup.com>
arvindr19
force-pushed
the
feat/proxy-doip
branch
2 times, most recently
from
7999eff to
a124253
Compare
arvindr19
changed the title
Signed-off-by: Arvind Rathod <Arvind.RA.Rathod@bti.bmwgroup.com>
arvindr19
force-pushed
the
feat/proxy-doip
branch
from
a124253 to
0dad30e
Compare
Signed-off-by: Arvind Rathod <Arvind.RA.Rathod@bti.bmwgroup.com>
Signed-off-by: Arvind Rathod <Arvind.RA.Rathod@bti.bmwgroup.com>
Signed-off-by: Arvind Rathod <Arvind.RA.Rathod@bti.bmwgroup.com>
Signed-off-by: Arvind Rathod <Arvind.RA.Rathod@bti.bmwgroup.com>
- Add UdsResponse<'a> wrapper with sid()/is_negative()/nrc() accessors
- is_negative_response/get_nrc delegate to UdsResponse — no more raw byte indexing
- Add ResolvedService { name, params } struct; replace (String, Map) tuple in
resolve_read_service / resolve_write_service return types
- Split resolve_service_did into build_did_candidates + match_candidate_did
- or_else + match pattern in activate_base_variant (replaces nested if/else)
- Add RwLock doc comment explaining write-reservation intent
- Remove redundant HashSet alongside Vec in candidate dedup
- Add #[cfg(test)] modules to resolve.rs, metadata.rs, response.rs
(6 + 9 + 12 new unit tests; 63 total in proxy-core)
…BI only) Signed-off-by: Arvind Rathod <Arvind.RA.Rathod@bti.bmwgroup.com>
arvindr19
force-pushed
the
feat/proxy-doip
branch
from
0dad30e to
b118a14
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
proxy-doipcrate: ISO 13400-2 DoIP TCP server, message parsing, session management, and UDS request dispatch.Depends on: PR #11 (proxy-core)
Changes
DoIpMessage: Parse/serialize DoIP frames (version check, payload types, header validation)RoutingActivationRequest/DiagnosticMessage: ISO 13400-2 payload parsersDoIpServer: TCP listener with connection limiting and per-connection async handlersSession: Routing activation state trackingConnectionHandler: Frame accumulation, UDS message dispatch toDiagHandler, negative response handling. Named constants for all protocol sizes and magic numbers.Scope
Handles only
ReadDataByIdentifier(0x22) andWriteDataByIdentifier(0x2E). Other SIDs returnServiceNotSupported(NRC 0x11).Checklist
Related
Notes for Reviewers
This is a temporary transport layer.
message.rs,server.rs,session.rs, andlib.rswill be replaced when integrating with eclipse-opensovd/uds2sovd-proxy#4 and follow-up PRs for the DoIP server.handler.rscontains the UDS dispatch logic and is the primary file for review.