Skip to content

Support variants in Markdown agents#540

Merged
ericdallo merged 2 commits into
editor-code-assistant:masterfrom
itkonen:feat/markdown-agent-variant
Jul 20, 2026
Merged

Support variants in Markdown agents#540
ericdallo merged 2 commits into
editor-code-assistant:masterfrom
itkonen:feat/markdown-agent-variant

Conversation

@itkonen

@itkonen itkonen commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Support trimmed, case-preserving variant values in Markdown agent frontmatter while ignoring blank or malformed values.
  • Cover loading, JSON precedence, and inheritance, and document JSON/Markdown agent variants with tabbed examples.

Testing

  • LC_ALL=C clojure -M:test --focus eca.features.agents-test

  • LC_ALL=C clojure -M:test --focus eca.config-test/resolve-agent-inheritance-test

  • LC_ALL=C bb test — 795 tests, 4451 assertions, 0 failures

  • Editor diagnostics: no issues

  • I added a entry in changelog under unreleased section.

  • This is not an AI slop.

🤖 Generated with ECA

Allow Markdown agent definitions to select the same default model variants as JSON-configured agents, with validation coverage and aligned documentation.

🤖 Generated with [ECA](https://eca.dev)

Co-Authored-By: eca-agent <git@eca.dev>

@ericdallo ericdallo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I don't recall why we didn't add support for that before, but makes sense to me rn, thank you
c/c @zikajk

@ericdallo

Copy link
Copy Markdown
Member

can you solve the conflicts please @itkonen ?

…-variant

# Conflicts:
#	CHANGELOG.md
#	src/eca/features/agents.clj
#	test/eca/features/agents_test.clj
@ericdallo
ericdallo merged commit 0228d81 into editor-code-assistant:master Jul 20, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants