fix(description): drop generated root URDFs and ignore them#72
Open
Bartok9 wants to merge 1 commit into
Open
Conversation
openarmv2.urdf and output.urdf are xacro-generated scratch files that were accidentally committed. The launch file builds URDFs on the fly, so these root artifacts should never ship. - Remove openarmv2.urdf and output.urdf - Enable *.urdf gitignore (was commented out) while keeping tracked assets/**/*.urdf(.xacro) via negation, and pin the two known scratch names
kou
reviewed
Jul 14, 2026
| scripts/ | ||
| # Accidental gen scratch files (never ship) | ||
| /openarmv2.urdf | ||
| /output.urdf |
Comment on lines
+16
to
+18
| *.urdf | ||
| !assets/**/*.urdf | ||
| !assets/**/*.urdf.xacro |
Contributor
There was a problem hiding this comment.
Suggested change
| *.urdf | |
| !assets/**/*.urdf | |
| !assets/**/*.urdf.xacro | |
| /*.urdf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from #71 as requested by @kou (thanks for the review!).
This PR does one thing: removes the two xacro-generated scratch files accidentally committed at the package root.
openarmv2.urdf(empty) andoutput.urdf(871-line generated) are build artifacts; the launch file generates URDFs on the fly, so they should never be tracked.*.urdfgitignore rule (previously commented out) while keeping trackedassets/**/*.urdf(.xacro)via negation, plus pin the two known scratch filenames.The
arm_typeerror-message change from #71 will follow in a separate PR.