test(ci): probe — drop mocha --exit on Windows backend tests#7856
Open
JohnMcLear wants to merge 2 commits into
Open
test(ci): probe — drop mocha --exit on Windows backend tests#7856JohnMcLear wants to merge 2 commits into
JohnMcLear wants to merge 2 commits into
Conversation
The Windows backend-tests workflow has invoked mocha with --exit since PR #7762, with the in-line comment: # --exit forces process.exit(failures) after the suite completes, # closing the post-suite event-loop drain window where Windows + # Node 24 hard-kills the process. Scoped to Windows so Linux/local # runs still surface real handle leaks via natural drain. That comment is a direct admission that a kill HAPPENS at the post-suite drain on Windows + Node 24, and --exit was added as a **mitigation that hides it**. The current silent-ELIFECYCLE flake fires MID-SUITE, but --exit is still in play after the dying test fires and may also be masking earlier signal. Probe: drop --exit on both Windows backend matrices. Expected outcomes on a passing run: - if Node still exits cleanly via natural drain → the original post-suite hard-kill bug from PR #7762 is no longer reproducible in current Node 24.x, and we've been carrying a workaround for nothing. - if a fresh hard-kill appears at post-suite drain → we now have a SECOND data point (different from the mid-suite flake) and can compare its signature to the mid-suite kill in artifacts. On a failing run (the mid-suite flake fires): - removing --exit may let mocha emit additional error reporting that --exit's process.exit() was suppressing. - or it may not change anything, which itself is a data point. This is a one-line probe on a separate branch from probe-flake-defender-eventlog-sidecar. Run in parallel; the two ask different questions. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
Review Summary by QodoProbe: remove mocha --exit flag from Windows backend tests
WalkthroughsDescription• Remove mocha --exit flag from Windows backend test matrices • Probe to diagnose post-suite process hard-kill on Windows + Node 24 • Investigate whether original mitigation from PR #7762 still needed • Enable detection of additional mocha error output without early exit Diagramflowchart LR
A["Windows Backend Tests"] -->|Remove --exit flag| B["Natural Process Drain"]
B -->|Outcome 1| C["Clean exit - bug resolved"]
B -->|Outcome 2| D["Post-suite hard-kill - new data point"]
B -->|Outcome 3| E["Mid-suite flake - unchanged behavior"]
File Changes1. .github/workflows/backend-tests.yml
|
Code Review by Qodo
1.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
One-line workflow probe on a separate branch from #7855: remove the
--exitflag frompnpm teston both Windows backend matrices.Why
The current workflow has been invoking
pnpm test -- --exiton Windows since PR #7762, with the comment:That's a direct admission of a known post-suite kill bug on Windows + Node 24, and
--exitwas added as a mitigation that hides it. The current silent-ELIFECYCLE flake fires mid-suite, but--exitis still in play after the dying test and may also be masking earlier signal.Drop it on a separate probe branch. Either:
--exit'sprocess.exit()was suppressing?Any of these is data we don't currently have.
Test plan
🤖 Generated with Claude Code