Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/backend-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ jobs:
# Node 24 hard-kills the process. Scoped to Windows so Linux/local
# runs still surface real handle leaks via natural drain.
set +e
pnpm test -- --exit
pnpm test
EXIT=$?
set -e
kill "$WATCHER_PID" 2>/dev/null || true
Expand Down Expand Up @@ -392,7 +392,7 @@ jobs:
# Node 24 hard-kills the process. Scoped to Windows so Linux/local
# runs still surface real handle leaks via natural drain.
set +e
pnpm test -- --exit
pnpm test
EXIT=$?
set -e
kill "$WATCHER_PID" 2>/dev/null || true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,14 +45,17 @@ describe('backend-tests flake mitigation (PR #7748)', () => {
.toBe(runStepCount);
});

it('Windows backend-test steps invoke pnpm test with --exit', () => {
// --exit is the Windows-only mitigation. Linux still runs natural-drain
// so leaked-handle regressions stay visible there.
it.skip('Windows backend-test steps invoke pnpm test with --exit (PROBE: temporarily disabled)', () => {
// PROBE branch only — see PR #7856. The original assertion enforced
// that the post-suite-drain mitigation from PR #7748 stays in place.
// This probe deliberately drops --exit to see whether (a) the original
// post-suite hard-kill bug still reproduces on current Node 24.x, or
// (b) --exit was also masking signal from the mid-suite silent flake.
// The .skip is REQUIRED for the probe branch to run; if this is in a
// PR targeted at develop, revert it before merge.
const exitCount = (workflow.match(/pnpm test -- --exit/g) || []).length;
expect(exitCount, 'Windows × 2 jobs must pass --exit to pnpm test')
.toBe(2);
// Negative check: Linux jobs must NOT use --exit so handle-leak
// detection stays alive on the natural-drain platforms.
expect(workflow.includes('runs-on: ubuntu-latest'),
'workflow no longer has any Linux jobs (sanity check)').toBe(true);
});
Expand Down
Loading