Add [coverage] config overrides for the pyrefly coverage globs#4146
Open
jorenham wants to merge 1 commit into
Open
Add [coverage] config overrides for the pyrefly coverage globs#4146jorenham wants to merge 1 commit into
[coverage] config overrides for the pyrefly coverage globs#4146jorenham wants to merge 1 commit into
Conversation
Contributor
Author
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This was referenced Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pyrefly coverage {check, report}used the sameproject-{includes,excludes}aspyrefly check, so measuring coverage on a different file set (e.g. skipping tests, vendored code, or publically-namespaced private API) required repeatedly specifiying--project-excludesfor everypyrefly coveragecall.This adds an optional
[coverage]config table withincludesandexcludesthat override the project globs when usingpyrefly coverage(and only then).Each field defaults to its top-level
project-counterpart when unset (like it does now).The
--project-excludesflag takes precedence overcoverage.excludes, and positionalFILES...args also do (just like with theproject-globs).Unknown keys inside
[coverage]are reported in a warning message in the same way as with the other config tables.Test Plan
Config tests added for parsing, path rewriting, and glob resolution (for both the "default" and "coverage" config scopes), and verified that a
[coverage]config indeed narrowspyrefly coverage reportwithout affectingpyrefly checkand explicitFILES...("file mode" I believe it's called).