Skip to content

[codex] fix project card link structure #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sean-Kenneth-Doherty wants to merge 2 commits into
base: main
Choose a base branch
from
+11 −11
Open

[codex] fix project card link structure #605

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35c623c
add noopener to card links
Sean-Kenneth-Doherty May 16, 2026
6f3f926
fix project card link structure
Sean-Kenneth-Doherty May 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/IssueList.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ if (repoInfo) {
{issues.length > 0 ? (
<div class="Issues-List">
{issues.map((issue) => (
<a href={issue.html_url} target="_blank" class="Issue-Card">
<a href={issue.html_url} target="_blank" rel="noopener noreferrer" class="Issue-Card">
<div class="Issue-Content">
<div class="Issue-Title">{issue.title}</div>
<div class="Issue-Meta">
Expand Down
15 changes: 7 additions & 8 deletions src/components/ProjectCard.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ const { projectLink, logoLink, name, description, tags = [], loadIssues = false
---

<div class="Card-Container">
<a class="Card-Real-Link" href={projectLink} target="_blank">
<div class="Card-Content" data-project-link={projectLink}>
<div class="Card-Header">
<img
class="Project-Logo"
Expand All @@ -41,10 +41,10 @@ const { projectLink, logoLink, name, description, tags = [], loadIssues = false
<IssueList projectLink={projectLink} projectName={name} />
)}
</div>
<div class="Card-Link">
<a class="Card-Link" href={projectLink} target="_blank" rel="noopener noreferrer">
<span>Go to Project</span>
</div>
</a>
</a>
</div>
</div>

<style>
Expand Down Expand Up @@ -86,9 +86,7 @@ const { projectLink, logoLink, name, description, tags = [], loadIssues = false
background: rgba(255, 255, 255, 0.12);
}

.Card-Real-Link {
display: block;
text-decoration: none;
.Card-Content {
color: inherit;
height: 100%;
display: flex;
Expand Down Expand Up @@ -157,6 +155,7 @@ const { projectLink, logoLink, name, description, tags = [], loadIssues = false


.Card-Link {
display: block;
background: linear-gradient(135deg, rgba(102, 126, 234, 0.8) 0%, rgba(118, 75, 162, 0.8) 100%);
backdrop-filter: blur(20px);
-webkit-backdrop-filter: blur(20px);
Expand All @@ -167,6 +166,7 @@ const { projectLink, logoLink, name, description, tags = [], loadIssues = false
font-weight: 600;
margin-top: auto;
border-radius: 12px;
text-decoration: none;
transition: all 0.3s ease;
position: relative;
overflow: hidden;
Expand Down Expand Up @@ -219,4 +219,3 @@ const { projectLink, logoLink, name, description, tags = [], loadIssues = false
}
}
</style>

5 changes: 3 additions & 2 deletions src/components/ProjectList.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,15 +42,16 @@ const allTags = [...new Set(projectList.flatMap(project => project.tags || []))]
<script>
// Get all projects data from the server-rendered content
const projectList = Array.from(document.querySelectorAll('.Card-Container')).map(card => {
const link = card.querySelector('.Card-Real-Link');
const link = card.querySelector('.Card-Link');
const title = card.querySelector('.Card-Title');
const description = card.querySelector('.Card-Description p');
const tags = Array.from(card.querySelectorAll('.Card-Tag p')).map(tag => tag.textContent);
const content = card.querySelector('.Card-Content');
const logo = card.querySelector('.Project-Logo');

return {
name: title?.textContent || '',
projectLink: link?.href || '',
projectLink: link?.href || content?.getAttribute('data-project-link') || '',
description: description?.textContent || '',
tags: tags,
imageSrc: logo?.src || '',
Expand Down