Skip to content

[codex] fix project card link structure#605

Open
Sean-Kenneth-Doherty wants to merge 2 commits into
firstcontributions:mainfrom
Sean-Kenneth-Doherty:codex/add-noopener-to-card-links
Open

[codex] fix project card link structure#605
Sean-Kenneth-Doherty wants to merge 2 commits into
firstcontributions:mainfrom
Sean-Kenneth-Doherty:codex/add-noopener-to-card-links

Conversation

@Sean-Kenneth-Doherty
Copy link
Copy Markdown

@Sean-Kenneth-Doherty Sean-Kenneth-Doherty commented May 16, 2026

Summary

  • replace the whole-card project anchor with a dedicated Go to Project anchor so issue links are no longer nested inside another link
  • keep the project-list filter script reading the project URL from the new CTA link, with a data-project-link fallback
  • add rel="noopener noreferrer" to project and issue links that open in a new tab

Fixes #535.
Addresses #561 and #347.

Validation

  • git diff --check main...HEAD
  • pnpm build
  • inspected built dist/index.html: max anchor depth is 1, no nested anchors, 152 project CTA links render, 9 issue links render, and all 168 target="_blank" anchors include rel="noopener noreferrer"
  • inspected built script: it reads .Card-Link, no longer reads .Card-Real-Link, and keeps the data-project-link fallback

@Sean-Kenneth-Doherty Sean-Kenneth-Doherty marked this pull request as ready for review May 16, 2026 22:09
@Sean-Kenneth-Doherty
Copy link
Copy Markdown
Author

Moved out of draft after local validation:

  • pnpm build
  • git diff --check
  • Source scan of src/public found all target="_blank" anchors already include rel="noopener noreferrer".
  • Built HTML scan of dist/index.html and dist/contribute-to-opensource/index.html found no blank-target anchors missing rel="noopener noreferrer".

@Sean-Kenneth-Doherty Sean-Kenneth-Doherty changed the title [codex] add noopener to card links [codex] fix project card link structure May 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: “Go to Project” button not working when open issues are shown

1 participant