-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Fix chrome 145 web tests #12486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix chrome 145 web tests #12486
Changes from all commits
dd3cd03
ad03d11
3a87753
fd27dd4
b13c761
ae555c7
e201441
0e1a6cd
624748e
a704d9b
dc07cab
221a7f1
ac64fbe
473afb3
3832fa3
5d7329d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Per my other comment, I think these files and the new shards should be reverted.
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. (Also, keeping the new shard would cause every PR to unconditionally run |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| tasks: | ||
| - name: prepare tool | ||
| script: .ci/scripts/prepare_tool.sh | ||
| infra_step: true # Note infra steps failing prevents "always" from running. | ||
| - name: download Dart deps | ||
| script: .ci/scripts/tool_runner.sh | ||
| args: ["fetch-deps", "--web", "--supporting-target-platforms-only"] | ||
| infra_step: true | ||
| - name: drive examples | ||
| script: .ci/scripts/tool_runner.sh | ||
| args: [ | ||
| "drive-examples", | ||
| "--web", | ||
| "--run-chromedriver", | ||
| "--packages=camera_web", | ||
| ] |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| tasks: | ||
| - name: prepare tool | ||
| script: .ci/scripts/prepare_tool.sh | ||
| infra_step: true # Note infra steps failing prevents "always" from running. | ||
| - name: download Dart deps | ||
| script: .ci/scripts/tool_runner.sh | ||
| args: ["fetch-deps", "--web", "--supporting-target-platforms-only"] | ||
| infra_step: true | ||
| - name: drive examples | ||
| script: .ci/scripts/tool_runner.sh | ||
| args: [ | ||
| "drive-examples", | ||
| "--web", | ||
| "--wasm", | ||
| "--run-chromedriver", | ||
| "--packages=camera_web", | ||
| ] |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| test_on: vm |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,3 +2,6 @@ | |
| - file_selector | ||
| # Waiting on https://github.com/flutter/flutter/issues/145149 | ||
| - google_maps_flutter/google_maps_flutter | ||
| # Moved to its own dedicated shard due to long test duration | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm very skeptical that long test duration is the problem here. I looked at the presubmit run before you added this commit, and found this header in the log: That means it started running If we have all the tests except this working, and this one is still hanging for reasons we don't understand yet, we should just disable this test entirely with a link to an issue tracking investigating, fixing, and re-enabling the test. |
||
| - camera/camera_web | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get (and link to) an issue for this with
packagesandp: waiting for stable updateso we find it when doing the next stable update.