Fix chrome 145 web tests - #12486
Conversation
…erences_tool out of non-vm testing
d0e535b to
ac64fbe
Compare
|
Looks like you're running into the same crash/timeout issues I am now. |
| - file_selector | ||
| # Waiting on https://github.com/flutter/flutter/issues/145149 | ||
| - google_maps_flutter/google_maps_flutter | ||
| # Moved to its own dedicated shard due to long test duration |
There was a problem hiding this comment.
I'm very skeptical that long test duration is the problem here. I looked at the presubmit run before you added this commit, and found this header in the log:
|| Running for packages/camera/camera_web [@1:59]
That means it started running camera_web tests two minutes into the run, and then timed out 58 minutes later. It seems much more likely to me that the camera_web tests are hanging than that they take exactly 59 minutes to successfully run. (Also, they only took 4.5 minutes the last time I see them succeeding in a roll.)
If we have all the tests except this working, and this one is still hanging for reasons we don't understand yet, we should just disable this test entirely with a link to an issue tracking investigating, fixing, and re-enabling the test.
There was a problem hiding this comment.
Per my other comment, I think these files and the new shards should be reverted.
There was a problem hiding this comment.
(Also, keeping the new shard would cause every PR to unconditionally run camera_web tests no matter what was being touched, which combined with the fact that it's presumably going to consume a machine for 60 minutes every time would be extremely wasteful of CI resources.)
| # TODO(mdebbar): Upgrade to Chrome 145 once Flutter stable includes the | ||
| # upstream flutter_tools fixes for Chrome 145 (flutter/flutter#190155 and | ||
| # flutter/flutter#190584) which pass --disable-search-engine-choice-screen | ||
| # and --disable-background-timer-throttling. |
There was a problem hiding this comment.
Let's get (and link to) an issue for this with packages and p: waiting for stable update so we find it when doing the next stable update.
3 participants
Fixes flutter/flutter#191149