fix(ci): L1 traceability accepts Refs/Updates/Resolves as valid issue links#605
Merged
Merged
Conversation
… links The L1 TRACEABILITY check rejected commits using `Refs #N` or `Updates #N` as progress markers on a long-lived epic issue, even though those are standard GitHub linking keywords. This caused legitimate stack-of-PRs work (e.g. multiple commits on #592) to fail the check on every PR until manually reworded. Accept the full canonical set of GitHub linking verbs: - Close(s) / Fix(es) / Resolve(s) -- closes on merge - Ref(s) -- references (work in progress) - Update(s) -- progress update on existing issue Semantics preserved: every commit still has to point at a numbered issue. We just stop pretending `Closes` is the only acceptable verb. Updates #592
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #606
Accept
Refs/Updates/Resolvesas valid L1 issue linksProblem
The L1 TRACEABILITY check in
l1-traceability.ymlonly acceptsCloses/Fixes #N. This rejects commits that useRefs #NorUpdates #Nas progress markers on a long-lived epic issue.Concrete impact: PR #593 (
feat/dlc10-rust→feat/trios-bridge) shows 8/21 commits failing the L1 check, even though they all reference issue #592 — just usingRefsorUpdatesinstead ofClosesbecause they're incremental progress on the same epic.Fix
Accept the full canonical set of GitHub linking verbs:
Regex changed:
Semantics preserved
Every commit still must point at a numbered issue. We just stop pretending
Closesis the only acceptable verb. The finalCloses #Non the merge-commit (or the last commit in the stack) is what actually closes the issue — that's GitHub's own semantics.Why now
This unblocks PR #593 (3-month FGG676 SPI-flash unblock, silicon-verified) and any future stack-of-PRs work on long-lived epics.
Also in this PR
Bump
docs/NOW.md"Last updated:" → 2026-05-14 (Gate 1 requirement).Compliance
.sh/.py(workflow YAML edit only)Updates #592— passes both old and new check