fix(cli): Guard markdown rendering against undefined input - #1422
Open
sentry[bot] wants to merge 1 commit into
Open
fix(cli): Guard markdown rendering against undefined input#1422sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a
TypeError: Cannot read properties of undefined (reading 'replace')that occurred whenmarked.lexer()received anundefinedinput.The root cause was identified as
p.slugbeingundefinedfor certain malformed project objects (e.g., from a self-hosted Sentry behind Cloudflare Access returning 302 redirects). Thisundefinedvalue was then passed directly torenderInlineMarkdownand subsequently tomarked.lexer(), which expects a string.The fix involves two complementary changes:
markdown.ts: Added nullish coalescing (?? '') tomarked.lexer()calls withinrenderInlineMarkdown(line 573) andrenderMarkdown(lines 553 and 556). This ensures that the markdown lexer always receives a string, even if the inputmdisundefinedornull.project/list.ts: Updated thePROJECTcolumn definition inPROJECT_COLUMNS(line 236) to include a nullish guard:(p) => p.slug || ''. This preventsundefinedp.slugvalues from ever reaching the markdown formatter, aligning its behavior with theORGandPLATFORMcolumns which already use this pattern.Fixes CLI-2GS