Skip to content

fix(cli): Guard markdown rendering against undefined input #1422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sentry wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

fix(cli): Guard markdown rendering against undefined input #1422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/cli/src/commands/project/list.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ async function resolveOrgsForAutoDetect(cwd: string): Promise<OrgResolution> {
/** Column definitions for the project table. */
const PROJECT_COLUMNS: Column<ProjectWithOrg>[] = [
{ header: "ORG", value: (p) => p.orgSlug || "" },
{ header: "PROJECT", value: (p) => p.slug },
{ header: "PROJECT", value: (p) => p.slug || "" },
{ header: "NAME", value: (p) => escapeMarkdownCell(p.name) },
{ header: "PLATFORM", value: (p) => p.platform || "" },
];
Expand Down
6 changes: 3 additions & 3 deletions packages/cli/src/lib/formatters/markdown.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -550,10 +550,10 @@ export function renderMarkdown(md: string): string {
// Parse and render to get structural formatting (headings, tables, lists),
// then strip ANSI codes. This produces human-readable output with aligned
// tables and proper heading emphasis, without ANSI escape sequences.
const tokens = marked.lexer(md);
const tokens = marked.lexer(md ?? "");
return stripAnsi(renderBlocks(tokens)).trimEnd();
}
const tokens = marked.lexer(md);
const tokens = marked.lexer(md ?? "");
return renderBlocks(tokens).trimEnd();
}

Expand All @@ -570,7 +570,7 @@ export function renderMarkdown(md: string): string {
* @returns Styled string (TTY) or plain text (non-TTY / plain mode)
*/
export function renderInlineMarkdown(md: string): string {
const tokens = marked.lexer(md);
const tokens = marked.lexer(md ?? "");
const rendered = renderInline(tokens.flatMap(flattenInline));
return isPlainOutput() ? stripAnsi(rendered) : rendered;
}
Loading