Skip to content

Make the --target-uploads-url option visible to the help output#1518

Closed
akordowski wants to merge 2 commits into
github:mainfrom
akordowski:fix/target-uploads-url-option
Closed

Make the --target-uploads-url option visible to the help output#1518
akordowski wants to merge 2 commits into
github:mainfrom
akordowski:fix/target-uploads-url-option

Conversation

@akordowski

Copy link
Copy Markdown
Contributor
  • Did you write/update appropriate tests
  • Release notes updated (if appropriate)
  • Appropriate logging output
  • Issue linked
  • Docs updated (or issue created)
  • New package licenses are added to ThirdPartyNotices.txt (if applicable)

This PR addresses the issue #1517 and makes the --target-uploads-url option visible to the help output.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR makes the --target-uploads-url command-line option visible in help output by removing the IsHidden = true property. Previously, this option was hidden from users running --help, making it difficult to discover and use when migrating to non-github.com targets.

Changes:

  • Removed IsHidden = true from the TargetUploadsUrl option across multiple command classes
  • Simplified the option initialization by removing the object initializer block

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/gei/Commands/MigrateRepo/MigrateRepoCommand.cs Made --target-uploads-url visible in the migrate-repo command help
src/gei/Commands/MigrateOrg/MigrateOrgCommand.cs Made --target-uploads-url visible in the migrate-org command help
src/gei/Commands/GenerateScript/GenerateScriptCommand.cs Made --target-uploads-url visible in the generate-script command help
src/bbs2gh/Commands/MigrateRepo/MigrateRepoCommand.cs Made --target-uploads-url visible in the bbs2gh migrate-repo command help

@github-actions

github-actions Bot commented Feb 26, 2026

Copy link
Copy Markdown

Unit Test Results

    1 files      1 suites   10m 25s ⏱️
1 030 tests 1 030 ✅ 0 💤 0 ❌
1 031 runs  1 031 ✅ 0 💤 0 ❌

Results for commit cd973e8.

♻️ This comment has been updated with latest results.

@github-actions

Copy link
Copy Markdown

Code Coverage

Package Line Rate Branch Rate Complexity Health
ado2gh 71% 70% 737
bbs2gh 83% 78% 663
gei 81% 73% 608
Octoshift 84% 73% 1810
Summary 81% (7934 / 9819) 73% (1947 / 2649) 3818

@ericfrederich

Copy link
Copy Markdown

Since this PR was created new commands have been added here like gl2gh which also takes the --target-uploads-url and is also hidden from --help.

These changes will likely have to be re-applied elsewhere.

@brianaj

brianaj commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

thanks for your contributions, closing in favor of #1593 so I can ship and release

@brianaj brianaj closed this Jul 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants