Show --target-uploads-url and --use-github-storage in --help#1593
Merged
Conversation
Unit Test Results 1 files 1 suites 25s ⏱️ Results for commit 779d7ce. ♻️ This comment has been updated with latest results. |
6 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes previously hidden CLI options discoverable by exposing --target-uploads-url and --use-github-storage in --help output for relevant migrate-repo, migrate-org, and generate-script commands across the gei, bbs2gh, and gl2gh extensions.
Changes:
- Unhides
--target-uploads-urland/or--use-github-storageby removingIsHidden = truefrom option definitions in the affected commands. - Updates unit tests to expect these options to be visible.
- Adds a release note entry describing the new
--helpvisibility.
Show a summary per file
| File | Description |
|---|---|
| src/gl2gh/Commands/MigrateRepo/MigrateRepoCommand.cs | Removes hidden flag from --target-uploads-url and --use-github-storage options. |
| src/gl2gh/Commands/GenerateScript/GenerateScriptCommand.cs | Removes hidden flag from --target-uploads-url and --use-github-storage options. |
| src/gei/Commands/MigrateRepo/MigrateRepoCommand.cs | Removes hidden flag from --target-uploads-url and --use-github-storage options. |
| src/gei/Commands/MigrateOrg/MigrateOrgCommand.cs | Removes hidden flag from --target-uploads-url option. |
| src/gei/Commands/GenerateScript/GenerateScriptCommand.cs | Removes hidden flag from --target-uploads-url and --use-github-storage options. |
| src/bbs2gh/Commands/MigrateRepo/MigrateRepoCommand.cs | Removes hidden flag from --target-uploads-url and --use-github-storage options. |
| src/bbs2gh/Commands/GenerateScript/GenerateScriptCommand.cs | Removes hidden flag from --use-github-storage option. |
| src/OctoshiftCLI.Tests/gl2gh/Commands/MigrateRepo/MigrateRepoCommandTests.cs | Updates assertions to expect options to be visible. |
| src/OctoshiftCLI.Tests/gl2gh/Commands/GenerateScript/GenerateScriptCommandTests.cs | Updates assertions to expect options to be visible. |
| src/OctoshiftCLI.Tests/gei/Commands/MigrateRepo/MigrateRepoCommandTests.cs | Updates assertions to expect options to be visible. |
| src/OctoshiftCLI.Tests/gei/Commands/MigrateOrg/MigrateOrgCommandTests.cs | Updates assertions to expect --target-uploads-url to be visible. |
| src/OctoshiftCLI.Tests/gei/Commands/GenerateScript/GenerateScriptCommandTests.cs | Updates assertions to expect options to be visible. |
| src/OctoshiftCLI.Tests/bbs2gh/Commands/MigrateRepo/MigrateRepoCommandTests.cs | Updates assertions to expect options to be visible. |
| src/OctoshiftCLI.Tests/bbs2gh/Commands/GenerateScript/GenerateScriptCommandTests.cs | Updates assertions to expect --use-github-storage to be visible. |
| RELEASENOTES.md | Adds a bullet describing the newly visible --help options. |
Review details
- Files reviewed: 15/15 changed files
- Comments generated: 1
- Review effort level: Low
dpmex4527
approved these changes
Jul 9, 2026
jeviet
approved these changes
Jul 9, 2026
jeviet
left a comment
jeviet
left a comment
Collaborator
There was a problem hiding this comment.
Approved -
Validated options - performed cursory check of spelling
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unhides the
--target-uploads-urland--use-github-storageoptions in--helpoutput for themigrate-repo,migrate-org, andgenerate-scriptcommands (where applicable) across thegei,bbs2gh, andgl2ghextensions.Closes #1517. Supersedes #1518 (thanks @akordowski for the original attempt).
Motivation
Customers using non-github.com targets or GitHub-owned storage need to discover these options without reading source code. They've been hidden by default, which caused repeated confusion in support conversations.
Changes
Removed
IsHidden = truefrom the option definitions in:src/gei/Commands/MigrateRepo/MigrateRepoCommand.cssrc/gei/Commands/MigrateOrg/MigrateOrgCommand.cssrc/gei/Commands/GenerateScript/GenerateScriptCommand.cssrc/bbs2gh/Commands/MigrateRepo/MigrateRepoCommand.cssrc/bbs2gh/Commands/GenerateScript/GenerateScriptCommand.cssrc/gl2gh/Commands/MigrateRepo/MigrateRepoCommand.cssrc/gl2gh/Commands/GenerateScript/GenerateScriptCommand.csUpdated the corresponding
VerifyCommandOptionassertions to expect the options to be visible.Added a release note bullet to
RELEASENOTES.md.ado2ghis unaffected since it is a non archive path.Verification
dotnet format src/OctoshiftCLI.sln— cleandotnet build src/OctoshiftCLI.sln /p:TreatWarningsAsErrors=true— 0 warnings, 0 errorsdotnet test src/OctoshiftCLI.Tests/OctoshiftCLI.Tests.csproj— 1113 passed, 0 failedDid you write/update appropriate tests
Release notes updated (if appropriate)
Appropriate logging output
Issue linked
Docs updated (or issue created)
New package licenses are added to
ThirdPartyNotices.txt(if applicable)