Remove deprecated permission property from NewTeam struct in CreateTeam.#4098
Open
maishivamhoo123 wants to merge 2 commits intogoogle:masterfrom
Open
Remove deprecated permission property from NewTeam struct in CreateTeam.#4098maishivamhoo123 wants to merge 2 commits intogoogle:masterfrom
maishivamhoo123 wants to merge 2 commits intogoogle:masterfrom
Conversation
Collaborator
|
@maishivamhoo123 - we have a challenge removing deprecated fields in this client library because we also support GitHub Enterprise users who often use this repo with older versions of GitHub Enterprise that still use deprecated fields. To support the new API, we won't necessarily be removing deprecated fields, but we may be marking fields as deprecated and adding support for new/modified endpoints, if that makes sense. |
Contributor
Author
|
@gmlewis Thanks for the clarification. I’ll keep this in mind for my next PR and make sure deprecated fields are handled appropriately. Thank you ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4077
Removed the deprecated permission property from the NewTeam struct request payload when a team is created.
Affected endpoints:
POST /orgs/{org}/teams