Skip to content

Remove deprecated permission property from NewTeam struct in CreateTeam. #4098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maishivamhoo123 wants to merge 2 commits into from
Closed

Remove deprecated permission property from NewTeam struct in CreateTeam. #4098

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d29e8e9
Remove deprecated permission property from NewTeam struct
maishivamhoo123 Mar 16, 2026
c5c645d
Merge branch 'master' into fix/Removed_deprecated_permission_property
maishivamhoo123 Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions github/github-accessors.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 0 additions & 11 deletions github/github-accessors_test.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions github/github-stringify_test.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 0 additions & 7 deletions github/teams.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,13 +171,6 @@ type NewTeam struct {
// NotificationSetting can be one of: "notifications_enabled", "notifications_disabled".
NotificationSetting *string `json:"notification_setting,omitempty"`

// Deprecated: Permission is deprecated when creating or editing a team in an org
// using the new GitHub permission model. It no longer identifies the
// permission a team has on its repos, but only specifies the default
// permission a repo is initially added with. Avoid confusion by
// specifying a permission value when calling AddTeamRepo.
Permission *string `json:"permission,omitempty"`

// Privacy identifies the level of privacy this team should have.
// Possible values are:
// secret - only visible to organization owners and members of this team
Expand Down
2 changes: 0 additions & 2 deletions github/teams_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1588,7 +1588,6 @@ func TestNewTeam_Marshal(t *testing.T) {
RepoNames: []string{"repo1", "repo2"},
NotificationSetting: Ptr("notifications_enabled"),
ParentTeamID: Ptr(int64(1)),
Permission: Ptr("perm"),
Privacy: Ptr("p"),
LDAPDN: Ptr("l"),
}
Expand All @@ -1600,7 +1599,6 @@ func TestNewTeam_Marshal(t *testing.T) {
"repo_names": ["repo1", "repo2"],
"parent_team_id": 1,
"notification_setting": "notifications_enabled",
"permission": "perm",
"privacy": "p",
"ldap_dn": "l"
}`
Expand Down