Skip to content

chore: add markers in pom.xml#13271

Draft
zhumin8 wants to merge 2 commits into
mainfrom
add-pom-markers
Draft

chore: add markers in pom.xml#13271
zhumin8 wants to merge 2 commits into
mainfrom
add-pom-markers

Conversation

@zhumin8
Copy link
Copy Markdown
Contributor

@zhumin8 zhumin8 commented May 26, 2026

Add comment markers in pom.xml for generated proto and grpc artifacts.
These markers are added in parent, BOM and client pom.xml files for each library.

Fixes googleapis/librarian#6134

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds generated dependency and module marker comments (such as <!-- {x-generated-dependencies-start} --> and <!-- {x-generated-dependencies-end} -->) to various pom.xml files across multiple Google Cloud Java client libraries. These markers are used to automate the management of generated dependencies and modules. I have no feedback to provide on these changes.

…tection, preventing them from being

  converted into broken tags

fix lint
@zhumin8 zhumin8 force-pushed the add-pom-markers branch from 38db038 to 45f17c4 Compare May 26, 2026 20:19
@sonarqubecloud
Copy link
Copy Markdown

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

google-cloud-java: raise PR for migrate -insert-markers

1 participant