chore: always run units jobs with step-level skips#13326
Merged
Conversation
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Member
|
IIUC, this seems to be a limitation of the Github CI. The required status for the matrix jobs aren't reported because they're never run (though Github CI docs does say that skipped jobs are reported as a success). I guess just not for matrix jobs. Might be another data point to try and move away from bulk jobs (needing to run all GAPIC unit tests). |
lqiu96
approved these changes
Jun 2, 2026
Contributor
Author
Yes exactly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR solves the issue where required checks
units (11),units (17),units (21),units (25), andunits (8)get stuck in a pending "stuck forever" state on GitHub.For example, https://screenshot.googleplex.com/9bpNwWP7jParbuM
Root Cause
The
unitsandunits-8-runtimejobs in.github/workflows/ci.yamlare conditionally skipped using job-levelif: ${{ needs.bulk-filter.outputs.runnable == 'true' }}.Because the entire job is skipped at the job-level, the matrix versions are not expanded, and status checks like
units (11)are never reported to GitHub. When these checks are configured directly as required status checks in branch protection rules, PRs that skip the jobs (e.g., workflow-only PRs) are stuck forever.Solution
We removed the job-level
if: runnable == trueconditional from bothunitsandunits-8-runtimejobs so they always start. Instead, we applied theif: runnable == truecheck to every individual step inside these jobs.When a PR doesn't need to run these checks: