Skip to content

H-6472: Replace Biome with Oxfmt for formatting#8716

Open
indietyp wants to merge 20 commits into
mainfrom
bm/h-6472-replace-biome-with-oxfmt
Open

H-6472: Replace Biome with Oxfmt for formatting#8716
indietyp wants to merge 20 commits into
mainfrom
bm/h-6472-replace-biome-with-oxfmt

Conversation

@indietyp
Copy link
Copy Markdown
Member

🌟 What is the purpose of this PR?

Replaces Biome with Oxfmt as the project formatter. Biome was only used for formatting (linter and import organizer were disabled), so this is a direct replacement.

Oxfmt picks up three things Biome had disabled pending v2: import sorting, package.json sorting, and Tailwind CSS class sorting.

🔗 Related links

🔍 What does this change?

  • Added oxfmt.config.ts with equivalent formatting rules
  • Updated all biome format invocations to oxfmt across:
    • Root package.json (lint:format, fix:format)
    • .lefthook.yml pre-commit hook
    • Codegen scripts (hash-api, hash-isomorphic-utils, internal-api-client, ds-components, repo-chores)
  • Updated mise install biome to mise install oxfmt in Dockerfiles and Vercel install scripts
  • Updated editor extension recommendations (VS Code, Zed)
  • Updated .github/actions/prune-repository to copy oxfmt.config.ts
  • Updated .github/CONTRIBUTING.md tool list
  • Removed biome.jsonc

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • does not modify any publishable blocks or libraries, or modifications do not need publishing

📜 Does this require a change to the docs?

The changes in this PR:

  • are internal and do not require a docs change

🕸️ Does this require a change to the Turbo Graph?

The changes in this PR:

  • do not affect the execution graph

🐾 Next steps

  • Replace ESLint with Oxlint

🛡 What tests cover this?

  • CI lint:format step exercises oxfmt --check on the full repo

❓ How to test this?

  1. Run yarn lint:format and confirm it passes
  2. Run yarn fix:format and confirm it formats correctly
  3. Confirm lefthook pre-commit hook runs oxfmt on staged files

@indietyp indietyp requested a review from a team as a code owner May 13, 2026 09:12
@vercel
Copy link
Copy Markdown

vercel Bot commented May 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hash Error Error May 19, 2026 7:49am
petrinaut Error Error May 19, 2026 7:49am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
hashdotdesign-tokens Ignored Ignored Preview May 19, 2026 7:49am

@cursor
Copy link
Copy Markdown

cursor Bot commented May 13, 2026

PR Summary

Medium Risk
Moderate risk due to repo-wide formatting/tooling migration (CI hooks, Docker/mise installs) and large mechanical diffs, though behavior should be unchanged outside of formatting and lint workflow adjustments.

Overview
Switches the repo formatter from Biome to Oxfmt. Adds oxfmt to tool management (mise) and updates dev/CI tooling to run oxfmt (pre-commit via lefthook, Docker build installs, and GitHub repo-prune action copying oxfmt.config.ts).

Updates docs/editor guidance (VS Code/Zed recommendations, CONTRIBUTING) and tweaks markdown linting to allow table column style variance. Also removes the yarn lint:package-json CI step and applies large-scale formatting-only changes across Markdown/JSONC/YAML and TypeScript (mostly import ordering/whitespace) including .claude skill docs and apps/hash-ai-worker-ts.

Reviewed by Cursor Bugbot for commit 1dd3d38. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown
Member Author

indietyp commented May 13, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions Bot added area/deps Relates to third-party dependencies (area) area/apps > hash* Affects HASH (a `hash-*` app) area/infra Relates to version control, CI, CD or IaC (area) area/apps > hash-api Affects the HASH API (app) area/infra > docker area/libs Relates to first-party libraries/crates/packages (area) type/eng > frontend Owned by the @frontend team type/eng > backend Owned by the @backend team area/tests New or updated tests area/tests > integration New or updated integration tests area/tests > playwright New or updated Playwright tests area/apps area/apps > hash-graph type/legal Owned by the @legal team area/apps > hash.design Affects the `hash.design` design site (app) labels May 13, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.25%. Comparing base (7b67b01) to head (1dd3d38).
⚠️ Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
.../shared/get-llm-response/get-anthropic-response.ts 0.00% 1 Missing ⚠️
...l/resolvers/knowledge/file/create-file-from-url.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8716      +/-   ##
==========================================
- Coverage   62.31%   62.25%   -0.07%     
==========================================
  Files        1354     1354              
  Lines      137313   137434     +121     
  Branches     5793     5816      +23     
==========================================
- Hits        85568    85558      -10     
- Misses      50838    50969     +131     
  Partials      907      907              
Flag Coverage Δ
apps.hash-ai-worker-ts 1.41% <0.00%> (ø)
apps.hash-api 0.00% <ø> (ø)
blockprotocol.type-system 40.84% <ø> (ø)
local.claude-hooks 0.00% <ø> (ø)
local.harpc-client 51.24% <ø> (ø)
local.hash-backend-utils 2.81% <ø> (ø)
local.hash-graph-sdk 9.63% <ø> (ø)
local.hash-isomorphic-utils 0.00% <ø> (ø)
rust.antsi 0.00% <ø> (ø)
rust.error-stack 90.87% <ø> (ø)
rust.harpc-codec 84.70% <ø> (ø)
rust.harpc-net 96.19% <ø> (-0.02%) ⬇️
rust.harpc-tower 67.03% <ø> (ø)
rust.harpc-types 0.00% <ø> (ø)
rust.harpc-wire-protocol 92.23% <ø> (ø)
rust.hash-codec 72.76% <ø> (ø)
rust.hash-graph-api 2.52% <ø> (ø)
rust.hash-graph-authorization 62.34% <ø> (ø)
rust.hash-graph-postgres-store 26.81% <ø> (ø)
rust.hash-graph-store 37.76% <ø> (ø)
rust.hash-graph-temporal-versioning 47.95% <ø> (ø)
rust.hash-graph-types 0.00% <ø> (ø)
rust.hash-graph-validation 83.45% <ø> (ø)
rust.hashql-core 82.44% <ø> (ø)
rust.hashql-diagnostics 72.43% <ø> (ø)
rust.hashql-syntax-jexpr 94.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 3 potential issues.

There are 4 total unresolved issues (including 1 from previous review).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 51bad65. Configure here.

Comment thread .claude/skills/writing-hashql-diagnostics/references/guidelines.md Outdated
Comment thread .github/licenses/LICENSE-CC.md Outdated
Comment thread README.md Outdated
Copy link
Copy Markdown
Member

@TimDiekmann TimDiekmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but we need to honor import order in some cases and ignore generated files.

Comment thread .config/mise/config.toml
Comment thread .github/licenses/LICENSE-CC.md
Comment thread .claude/skills/skill-creator/assets/SKILL.template.md Outdated
Comment on lines +7 to +9
type: domain # "domain" (advisory) or "guardrail" (enforced)
enforcement: suggest # "suggest", "warn", or "block"
priority: medium # "critical", "high", "medium", or "low"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I liked the previous version more, but also don't feel strongly.

Comment thread .config/agents/README.md
Comment on lines -1 to -2
Agent rules and symlinks
========================
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personal preference: === as header is easier to read when looking at markdown, but you need to know that === is h1 and --- is h2

@@ -1,11 +1,11 @@
/* eslint-disable import/first, import/order, simple-import-sort/imports */

import * as Sentry from "@sentry/node";
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Import order must not change

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is autogenerated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is autogenerated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is autogenerated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is autogenerated

@indietyp indietyp force-pushed the bm/h-6472-replace-biome-with-oxfmt branch from 358b0a4 to 1dd3d38 Compare May 18, 2026 07:37
if (transition.id === "__proto__") {
throw new Error("Cannot add transition with id '__proto__'");
}

@github-actions
Copy link
Copy Markdown
Contributor

Benchmark results

@rust/hash-graph-benches – Integrations

policy_resolution_large

Function Value Mean Flame graphs
resolve_policies_for_actor user: empty, selectivity: high, policies: 2002 $$26.7 \mathrm{ms} \pm 183 \mathrm{μs}\left({\color{gray}-0.680 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: empty, selectivity: low, policies: 1 $$3.37 \mathrm{ms} \pm 17.2 \mathrm{μs}\left({\color{gray}-0.587 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: empty, selectivity: medium, policies: 1001 $$12.0 \mathrm{ms} \pm 75.1 \mathrm{μs}\left({\color{gray}-0.378 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: seeded, selectivity: high, policies: 3314 $$41.9 \mathrm{ms} \pm 296 \mathrm{μs}\left({\color{gray}-0.832 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: seeded, selectivity: low, policies: 1 $$13.6 \mathrm{ms} \pm 110 \mathrm{μs}\left({\color{gray}-0.323 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: seeded, selectivity: medium, policies: 1526 $$22.8 \mathrm{ms} \pm 182 \mathrm{μs}\left({\color{gray}0.047 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: system, selectivity: high, policies: 2078 $$27.4 \mathrm{ms} \pm 159 \mathrm{μs}\left({\color{gray}-0.804 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: system, selectivity: low, policies: 1 $$3.67 \mathrm{ms} \pm 18.1 \mathrm{μs}\left({\color{gray}0.378 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: system, selectivity: medium, policies: 1033 $$12.9 \mathrm{ms} \pm 82.6 \mathrm{μs}\left({\color{gray}-1.454 \mathrm{\%}}\right) $$ Flame Graph

policy_resolution_medium

Function Value Mean Flame graphs
resolve_policies_for_actor user: empty, selectivity: high, policies: 102 $$3.74 \mathrm{ms} \pm 20.4 \mathrm{μs}\left({\color{gray}-1.160 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: empty, selectivity: low, policies: 1 $$2.95 \mathrm{ms} \pm 16.0 \mathrm{μs}\left({\color{gray}-0.302 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: empty, selectivity: medium, policies: 51 $$3.30 \mathrm{ms} \pm 17.6 \mathrm{μs}\left({\color{gray}-0.466 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: seeded, selectivity: high, policies: 269 $$5.14 \mathrm{ms} \pm 26.3 \mathrm{μs}\left({\color{gray}-0.659 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: seeded, selectivity: low, policies: 1 $$3.46 \mathrm{ms} \pm 16.6 \mathrm{μs}\left({\color{gray}-1.372 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: seeded, selectivity: medium, policies: 107 $$4.09 \mathrm{ms} \pm 20.3 \mathrm{μs}\left({\color{gray}-0.761 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: system, selectivity: high, policies: 133 $$4.44 \mathrm{ms} \pm 26.8 \mathrm{μs}\left({\color{gray}0.808 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: system, selectivity: low, policies: 1 $$3.35 \mathrm{ms} \pm 16.3 \mathrm{μs}\left({\color{gray}-0.682 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: system, selectivity: medium, policies: 63 $$4.11 \mathrm{ms} \pm 19.9 \mathrm{μs}\left({\color{gray}1.56 \mathrm{\%}}\right) $$ Flame Graph

policy_resolution_none

Function Value Mean Flame graphs
resolve_policies_for_actor user: empty, selectivity: high, policies: 2 $$2.68 \mathrm{ms} \pm 12.2 \mathrm{μs}\left({\color{gray}-1.006 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: empty, selectivity: low, policies: 1 $$2.61 \mathrm{ms} \pm 13.9 \mathrm{μs}\left({\color{gray}-1.042 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: empty, selectivity: medium, policies: 1 $$2.76 \mathrm{ms} \pm 15.5 \mathrm{μs}\left({\color{gray}-0.379 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: system, selectivity: high, policies: 8 $$2.97 \mathrm{ms} \pm 16.1 \mathrm{μs}\left({\color{gray}-1.346 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: system, selectivity: low, policies: 1 $$2.78 \mathrm{ms} \pm 15.0 \mathrm{μs}\left({\color{gray}-0.969 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: system, selectivity: medium, policies: 3 $$3.10 \mathrm{ms} \pm 15.8 \mathrm{μs}\left({\color{gray}-0.656 \mathrm{\%}}\right) $$ Flame Graph

policy_resolution_small

Function Value Mean Flame graphs
resolve_policies_for_actor user: empty, selectivity: high, policies: 52 $$3.03 \mathrm{ms} \pm 14.2 \mathrm{μs}\left({\color{gray}-1.512 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: empty, selectivity: low, policies: 1 $$2.73 \mathrm{ms} \pm 15.1 \mathrm{μs}\left({\color{gray}0.007 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: empty, selectivity: medium, policies: 25 $$2.92 \mathrm{ms} \pm 17.3 \mathrm{μs}\left({\color{gray}-0.125 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: seeded, selectivity: high, policies: 94 $$3.47 \mathrm{ms} \pm 17.1 \mathrm{μs}\left({\color{gray}-0.634 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: seeded, selectivity: low, policies: 1 $$3.00 \mathrm{ms} \pm 14.7 \mathrm{μs}\left({\color{gray}-0.556 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: seeded, selectivity: medium, policies: 26 $$3.23 \mathrm{ms} \pm 16.9 \mathrm{μs}\left({\color{gray}-0.844 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: system, selectivity: high, policies: 66 $$3.41 \mathrm{ms} \pm 14.8 \mathrm{μs}\left({\color{gray}-0.280 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: system, selectivity: low, policies: 1 $$2.95 \mathrm{ms} \pm 14.9 \mathrm{μs}\left({\color{gray}-1.536 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: system, selectivity: medium, policies: 29 $$3.33 \mathrm{ms} \pm 20.6 \mathrm{μs}\left({\color{gray}0.041 \mathrm{\%}}\right) $$ Flame Graph

read_scaling_complete

Function Value Mean Flame graphs
entity_by_id;one_depth 1 entities $$43.5 \mathrm{ms} \pm 199 \mathrm{μs}\left({\color{gray}-1.649 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id;one_depth 10 entities $$80.2 \mathrm{ms} \pm 430 \mathrm{μs}\left({\color{gray}-1.610 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id;one_depth 25 entities $$47.6 \mathrm{ms} \pm 239 \mathrm{μs}\left({\color{gray}-3.817 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id;one_depth 5 entities $$51.7 \mathrm{ms} \pm 350 \mathrm{μs}\left({\color{gray}1.63 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id;one_depth 50 entities $$59.1 \mathrm{ms} \pm 441 \mathrm{μs}\left({\color{gray}-4.012 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id;two_depth 1 entities $$44.4 \mathrm{ms} \pm 219 \mathrm{μs}\left({\color{gray}-4.005 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id;two_depth 10 entities $$419 \mathrm{ms} \pm 1.21 \mathrm{ms}\left({\color{gray}-0.428 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id;two_depth 25 entities $$98.7 \mathrm{ms} \pm 542 \mathrm{μs}\left({\color{gray}-1.145 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id;two_depth 5 entities $$88.6 \mathrm{ms} \pm 401 \mathrm{μs}\left({\color{gray}-1.570 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id;two_depth 50 entities $$280 \mathrm{ms} \pm 1.03 \mathrm{ms}\left({\color{gray}-2.133 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id;zero_depth 1 entities $$19.0 \mathrm{ms} \pm 117 \mathrm{μs}\left({\color{gray}-1.501 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id;zero_depth 10 entities $$19.8 \mathrm{ms} \pm 115 \mathrm{μs}\left({\color{gray}1.33 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id;zero_depth 25 entities $$19.7 \mathrm{ms} \pm 122 \mathrm{μs}\left({\color{gray}-0.977 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id;zero_depth 5 entities $$19.7 \mathrm{ms} \pm 109 \mathrm{μs}\left({\color{gray}-0.282 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id;zero_depth 50 entities $$23.6 \mathrm{ms} \pm 167 \mathrm{μs}\left({\color{gray}-1.489 \mathrm{\%}}\right) $$ Flame Graph

read_scaling_linkless

Function Value Mean Flame graphs
entity_by_id 1 entities $$18.9 \mathrm{ms} \pm 122 \mathrm{μs}\left({\color{gray}-1.896 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10 entities $$19.1 \mathrm{ms} \pm 148 \mathrm{μs}\left({\color{gray}-0.710 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 100 entities $$19.0 \mathrm{ms} \pm 120 \mathrm{μs}\left({\color{gray}-1.134 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1000 entities $$19.2 \mathrm{ms} \pm 112 \mathrm{μs}\left({\color{gray}-1.278 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10000 entities $$25.2 \mathrm{ms} \pm 195 \mathrm{μs}\left({\color{gray}-0.099 \mathrm{\%}}\right) $$ Flame Graph

representative_read_entity

Function Value Mean Flame graphs
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/block/v/1 $$33.9 \mathrm{ms} \pm 317 \mathrm{μs}\left({\color{gray}3.35 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/book/v/1 $$32.5 \mathrm{ms} \pm 307 \mathrm{μs}\left({\color{gray}0.806 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/building/v/1 $$32.2 \mathrm{ms} \pm 288 \mathrm{μs}\left({\color{lightgreen}-5.721 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/organization/v/1 $$32.3 \mathrm{ms} \pm 260 \mathrm{μs}\left({\color{gray}-2.236 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/page/v/2 $$33.8 \mathrm{ms} \pm 293 \mathrm{μs}\left({\color{gray}3.54 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/person/v/1 $$33.2 \mathrm{ms} \pm 320 \mathrm{μs}\left({\color{gray}-0.725 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/playlist/v/1 $$33.2 \mathrm{ms} \pm 283 \mathrm{μs}\left({\color{gray}-0.448 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/song/v/1 $$32.3 \mathrm{ms} \pm 270 \mathrm{μs}\left({\color{gray}-4.250 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/uk-address/v/1 $$33.7 \mathrm{ms} \pm 329 \mathrm{μs}\left({\color{gray}1.97 \mathrm{\%}}\right) $$ Flame Graph

representative_read_entity_type

Function Value Mean Flame graphs
get_entity_type_by_id Account ID: bf5a9ef5-dc3b-43cf-a291-6210c0321eba $$8.27 \mathrm{ms} \pm 44.4 \mathrm{μs}\left({\color{gray}-1.671 \mathrm{\%}}\right) $$ Flame Graph

representative_read_multiple_entities

Function Value Mean Flame graphs
entity_by_property traversal_paths=0 0 $$89.7 \mathrm{ms} \pm 516 \mathrm{μs}\left({\color{gray}-0.790 \mathrm{\%}}\right) $$
entity_by_property traversal_paths=255 1,resolve_depths=inherit:1;values:255;properties:255;links:127;link_dests:126;type:true $$142 \mathrm{ms} \pm 689 \mathrm{μs}\left({\color{gray}-0.033 \mathrm{\%}}\right) $$
entity_by_property traversal_paths=2 1,resolve_depths=inherit:0;values:0;properties:0;links:0;link_dests:0;type:false $$97.6 \mathrm{ms} \pm 500 \mathrm{μs}\left({\color{gray}0.069 \mathrm{\%}}\right) $$
entity_by_property traversal_paths=2 1,resolve_depths=inherit:0;values:0;properties:0;links:1;link_dests:0;type:true $$106 \mathrm{ms} \pm 626 \mathrm{μs}\left({\color{gray}0.303 \mathrm{\%}}\right) $$
entity_by_property traversal_paths=2 1,resolve_depths=inherit:0;values:0;properties:2;links:1;link_dests:0;type:true $$114 \mathrm{ms} \pm 660 \mathrm{μs}\left({\color{gray}0.263 \mathrm{\%}}\right) $$
entity_by_property traversal_paths=2 1,resolve_depths=inherit:0;values:2;properties:2;links:1;link_dests:0;type:true $$121 \mathrm{ms} \pm 573 \mathrm{μs}\left({\color{gray}-0.434 \mathrm{\%}}\right) $$
link_by_source_by_property traversal_paths=0 0 $$99.0 \mathrm{ms} \pm 605 \mathrm{μs}\left({\color{gray}1.11 \mathrm{\%}}\right) $$
link_by_source_by_property traversal_paths=255 1,resolve_depths=inherit:1;values:255;properties:255;links:127;link_dests:126;type:true $$126 \mathrm{ms} \pm 577 \mathrm{μs}\left({\color{gray}0.439 \mathrm{\%}}\right) $$
link_by_source_by_property traversal_paths=2 1,resolve_depths=inherit:0;values:0;properties:0;links:0;link_dests:0;type:false $$105 \mathrm{ms} \pm 533 \mathrm{μs}\left({\color{gray}-0.077 \mathrm{\%}}\right) $$
link_by_source_by_property traversal_paths=2 1,resolve_depths=inherit:0;values:0;properties:0;links:1;link_dests:0;type:true $$114 \mathrm{ms} \pm 522 \mathrm{μs}\left({\color{gray}0.487 \mathrm{\%}}\right) $$
link_by_source_by_property traversal_paths=2 1,resolve_depths=inherit:0;values:0;properties:2;links:1;link_dests:0;type:true $$116 \mathrm{ms} \pm 579 \mathrm{μs}\left({\color{gray}0.161 \mathrm{\%}}\right) $$
link_by_source_by_property traversal_paths=2 1,resolve_depths=inherit:0;values:2;properties:2;links:1;link_dests:0;type:true $$116 \mathrm{ms} \pm 565 \mathrm{μs}\left({\color{gray}-0.072 \mathrm{\%}}\right) $$

scenarios

Function Value Mean Flame graphs
full_test query-limited $$135 \mathrm{ms} \pm 649 \mathrm{μs}\left({\color{gray}-4.017 \mathrm{\%}}\right) $$ Flame Graph
full_test query-unlimited $$143 \mathrm{ms} \pm 597 \mathrm{μs}\left({\color{lightgreen}-5.142 \mathrm{\%}}\right) $$ Flame Graph
linked_queries query-limited $$102 \mathrm{ms} \pm 536 \mathrm{μs}\left({\color{gray}-1.976 \mathrm{\%}}\right) $$ Flame Graph
linked_queries query-unlimited $$557 \mathrm{ms} \pm 3.20 \mathrm{ms}\left({\color{gray}-4.033 \mathrm{\%}}\right) $$ Flame Graph

Comment on lines +67 to +69
<IconButton
size="xs"
variant="outline"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems the formatter was applied on a previous version.
This was changed by @alex-e-leon recently (merged Friday)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @kube - yeah @indietyp you'll need to be careful when rebasing that you don't accidentally revert any changes that have been merged in since you started this PR.

Might be easiest to just re-apply the formatting from scratch on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/apps > hash.design Affects the `hash.design` design site (app) area/apps > hash* Affects HASH (a `hash-*` app) area/apps > hash-api Affects the HASH API (app) area/apps area/deps Relates to third-party dependencies (area) area/infra > docker area/infra Relates to version control, CI, CD or IaC (area) area/libs Relates to first-party libraries/crates/packages (area) area/tests > integration New or updated integration tests area/tests > playwright New or updated Playwright tests area/tests New or updated tests type/eng > backend Owned by the @backend team type/eng > frontend Owned by the @frontend team type/legal Owned by the @legal team

Development

Successfully merging this pull request may close these issues.

5 participants