Skip to content

H-6474: remove shared libs .gitignore#8726

Merged
indietyp merged 2 commits into
mainfrom
bm/h-6474-remove-libs-gitignore-file
May 18, 2026
Merged

H-6474: remove shared libs .gitignore#8726
indietyp merged 2 commits into
mainfrom
bm/h-6474-remove-libs-gitignore-file

Conversation

@indietyp
Copy link
Copy Markdown
Member

🌟 What is the purpose of this PR?

  • Removes the libs/.gitignore

🔍 What does this change?

  • Removed the shared libs/.gitignore that was previously excluding Cargo.lock files from version control.
  • Added a Cargo.lock for libs/@local/hash-authorization, pinning its full dependency tree including authorization, codec, graph-types, reqwest, tokio, utoipa, and related transitive dependencies.
  • Added a Cargo.lock for libs/antsi, pinning its minimal dependency tree.
  • Added a Cargo.lock for libs/error-stack, pinning its dependency tree including test and dev dependencies such as insta, trybuild, tracing-subscriber, and related crates.

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • modifies a Cargo-publishable library, but it is not yet ready to publish

📜 Does this require a change to the docs?

The changes in this PR:

  • are internal and do not require a docs change

🕸️ Does this require a change to the Turbo Graph?

The changes in this PR:

  • do not affect the execution graph

🛡 What tests cover this?

  • Existing CI pipelines that build and test each Rust library will now use the pinned lockfiles.

❓ How to test this?

  1. Checkout the branch.
  2. Run cargo build or cargo test within any of the affected library directories (libs/@local/hash-authorization, libs/antsi, libs/error-stack).
  3. Confirm that the build resolves dependencies using the committed Cargo.lock without errors.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 18, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hash Ready Ready Preview, Comment May 18, 2026 8:13am
petrinaut Ready Ready Preview May 18, 2026 8:13am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
hashdotdesign-tokens Ignored Ignored Preview May 18, 2026 8:13am

@cursor
Copy link
Copy Markdown

cursor Bot commented May 18, 2026

PR Summary

Low Risk
Low risk change removing a libs/.gitignore entry; the main impact is that previously-ignored files under libs/ (e.g., Cargo.lock) may now be committed/tracked.

Overview
Removes the shared libs/.gitignore, so libs/ no longer ignores Cargo.lock/analysis and related artifacts can be tracked by git.

Reviewed by Cursor Bugbot for commit 0e3720c. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions github-actions Bot added area/deps Relates to third-party dependencies (area) area/apps > hash* Affects HASH (a `hash-*` app) area/infra Relates to version control, CI, CD or IaC (area) area/libs > error-stack Affects the `error-stack` crate (library) area/libs Relates to first-party libraries/crates/packages (area) area/libs > antsi Affects the `antsi` crate (library) type/eng > backend Owned by the @backend team labels May 18, 2026
Copy link
Copy Markdown
Member Author

indietyp commented May 18, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@indietyp indietyp changed the base branch from bm/h-6472-replace-biome-with-oxfmt to graphite-base/8726 May 18, 2026 07:59
@indietyp indietyp force-pushed the bm/h-6474-remove-libs-gitignore-file branch from 10ae7a2 to e5c0d04 Compare May 18, 2026 07:59
@indietyp indietyp force-pushed the graphite-base/8726 branch from 1dd3d38 to 2c1c977 Compare May 18, 2026 07:59
@indietyp indietyp changed the base branch from graphite-base/8726 to main May 18, 2026 07:59
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 18, 2026

Dependency Review

The following issues were found:

  • ❌ 10 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ⚠️ 1 package(s) with unknown licenses.
  • ⚠️ 18 packages with OpenSSF Scorecard issues.

View full job summary

@augmentcode
Copy link
Copy Markdown

augmentcode Bot commented May 18, 2026

🤖 Augment PR Summary

Summary: This PR removes the shared libs/.gitignore entry that prevented Rust lockfiles from being committed, improving dependency reproducibility for individual libraries.

Changes:

  • Removes libs/.gitignore rules that ignored Cargo.lock (and an analysis path) within /libs.
  • Adds a committed Cargo.lock for libs/@local/hash-authorization.
  • Adds a committed Cargo.lock for libs/antsi.
  • Adds a committed Cargo.lock for libs/error-stack.

Technical Notes: With per-library lockfiles tracked, builds/tests run from those library directories should resolve dependencies deterministically using the committed Cargo.lock.

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit e5c0d04. Configure here.

Comment thread libs/error-stack/Cargo.lock Outdated
Comment thread libs/@local/hash-authorization/Cargo.lock Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.31%. Comparing base (7b67b01) to head (e5c0d04).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8726   +/-   ##
=======================================
  Coverage   62.31%   62.31%           
=======================================
  Files        1354     1354           
  Lines      137313   137313           
  Branches     5793     5793           
=======================================
+ Hits        85568    85569    +1     
+ Misses      50838    50837    -1     
  Partials      907      907           
Flag Coverage Δ
apps.hash-ai-worker-ts 1.41% <ø> (ø)
apps.hash-api 0.00% <ø> (ø)
blockprotocol.type-system 40.84% <ø> (ø)
local.harpc-client 51.24% <ø> (ø)
local.hash-backend-utils 2.81% <ø> (ø)
local.hash-graph-sdk 9.63% <ø> (ø)
local.hash-isomorphic-utils 0.00% <ø> (ø)
rust.antsi 0.00% <ø> (ø)
rust.error-stack 90.87% <ø> (ø)
rust.harpc-codec 84.70% <ø> (ø)
rust.harpc-net 96.22% <ø> (+0.01%) ⬆️
rust.harpc-tower 67.03% <ø> (ø)
rust.harpc-wire-protocol 92.23% <ø> (ø)
rust.hash-codec 72.76% <ø> (ø)
rust.hash-graph-api 2.52% <ø> (ø)
rust.hash-graph-authorization 62.34% <ø> (ø)
rust.hash-graph-postgres-store 26.81% <ø> (ø)
rust.hash-graph-store 37.76% <ø> (ø)
rust.hash-graph-temporal-versioning 47.95% <ø> (ø)
rust.hash-graph-types 0.00% <ø> (ø)
rust.hash-graph-validation 83.45% <ø> (ø)
rust.hashql-ast 87.23% <ø> (ø)
rust.hashql-compiletest 29.63% <ø> (ø)
rust.hashql-core 82.44% <ø> (ø)
rust.hashql-eval 62.99% <ø> (ø)
rust.hashql-hir 89.06% <ø> (ø)
rust.hashql-mir 92.08% <ø> (ø)
rust.hashql-syntax-jexpr 94.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 18, 2026

Merging this PR will not alter performance

✅ 80 untouched benchmarks


Comparing bm/h-6474-remove-libs-gitignore-file (10ae7a2) with main (7b67b01)1

Open in CodSpeed

Footnotes

  1. No successful run was found on main (2c1c977) during the generation of this report, so 7b67b01 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Copy link
Copy Markdown
Member

@TimDiekmann TimDiekmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove the orphaned lock files?

Copy link
Copy Markdown
Member Author

Could you remove the orphaned lock files?

​fixed, they somehow slipped in from my own state :P

@github-actions github-actions Bot removed area/deps Relates to third-party dependencies (area) area/apps > hash* Affects HASH (a `hash-*` app) area/libs > error-stack Affects the `error-stack` crate (library) labels May 18, 2026
@github-actions github-actions Bot removed area/libs > antsi Affects the `antsi` crate (library) type/eng > backend Owned by the @backend team labels May 18, 2026
@indietyp indietyp enabled auto-merge May 18, 2026 08:18
@indietyp indietyp added this pull request to the merge queue May 18, 2026
Merged via the queue into main with commit 2bc58c4 May 18, 2026
41 checks passed
@indietyp indietyp deleted the bm/h-6474-remove-libs-gitignore-file branch May 18, 2026 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/infra Relates to version control, CI, CD or IaC (area) area/libs Relates to first-party libraries/crates/packages (area)

Development

Successfully merging this pull request may close these issues.

2 participants