H-6474: remove shared libs .gitignore#8726
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
PR SummaryLow Risk Overview Reviewed by Cursor Bugbot for commit 0e3720c. Bugbot is set up for automated code reviews on this repo. Configure here. |
10ae7a2 to
e5c0d04
Compare
1dd3d38 to
2c1c977
Compare
Dependency ReviewThe following issues were found:
|
🤖 Augment PR SummarySummary: This PR removes the shared Changes:
Technical Notes: With per-library lockfiles tracked, builds/tests run from those library directories should resolve dependencies deterministically using the committed 🤖 Was this summary useful? React with 👍 or 👎 |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e5c0d04. Configure here.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8726 +/- ##
=======================================
Coverage 62.31% 62.31%
=======================================
Files 1354 1354
Lines 137313 137313
Branches 5793 5793
=======================================
+ Hits 85568 85569 +1
+ Misses 50838 50837 -1
Partials 907 907 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
TimDiekmann
left a comment
There was a problem hiding this comment.
Could you remove the orphaned lock files?
fixed, they somehow slipped in from my own state :P |


🌟 What is the purpose of this PR?
libs/.gitignore🔍 What does this change?
libs/.gitignorethat was previously excludingCargo.lockfiles from version control.Cargo.lockforlibs/@local/hash-authorization, pinning its full dependency tree includingauthorization,codec,graph-types,reqwest,tokio,utoipa, and related transitive dependencies.Cargo.lockforlibs/antsi, pinning its minimal dependency tree.Cargo.lockforlibs/error-stack, pinning its dependency tree including test and dev dependencies such asinsta,trybuild,tracing-subscriber, and related crates.Pre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
This PR:
📜 Does this require a change to the docs?
The changes in this PR:
🕸️ Does this require a change to the Turbo Graph?
The changes in this PR:
🛡 What tests cover this?
❓ How to test this?
cargo buildorcargo testwithin any of the affected library directories (libs/@local/hash-authorization,libs/antsi,libs/error-stack).Cargo.lockwithout errors.