Skip to content

Remove deprecated InorbitConnectorConfig class#69

Merged
b-Tomas merged 2 commits into
nextfrom
breaking/remove-inorbit-connector-config
May 20, 2026
Merged

Remove deprecated InorbitConnectorConfig class#69
b-Tomas merged 2 commits into
nextfrom
breaking/remove-inorbit-connector-config

Conversation

@b-Tomas
Copy link
Copy Markdown
Member

@b-Tomas b-Tomas commented May 19, 2026

Summary

  • Remove InorbitConnectorConfig class from models.py and the isinstance guard + deprecation warning in Connector.__init__
  • Convert all tests to use ConnectorConfig with fleet param; port env-var tests to TestConnectorConfig
  • Remove import warnings from connector.py (no longer needed)
  • Remove deprecated section from docs/contents/specification/models.md

Breaking changes

InorbitConnectorConfig has been removed. Connectors that subclass or instantiate it must switch to ConnectorConfig with a fleet list:

# Before
from inorbit_connector.models import InorbitConnectorConfig

config = InorbitConnectorConfig(
    api_key="...",
    connector_type="my_connector",
    connector_config=MyConfig(),
)
connector = Connector("robot_1", config)

# After
from inorbit_connector.models import ConnectorConfig, RobotConfig

config = ConnectorConfig(
    api_key="...",
    connector_type="my_connector",
    connector_config=MyConfig(),
    fleet=[RobotConfig(robot_id="robot_1")],
)
connector = Connector("robot_1", config)

The to_fleet_config() conversion method is also removed — callers already have the fleet structure.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the deprecated InorbitConnectorConfig class and its to_fleet_config() helper from the models module, eliminating the corresponding isinstance branch and DeprecationWarning in Connector.__init__. Tests are migrated to instantiate ConnectorConfig directly with a fleet=[RobotConfig(...)] argument, and the related deprecation section in the docs is dropped.

Changes:

  • Drop InorbitConnectorConfig class and to_fleet_config() from models.py; simplify Connector.__init__ to always call to_singular_config().
  • Port all test_connector.py / test_models.py cases (including env-var tests) to ConnectorConfig + RobotConfig, removing filterwarnings decorators.
  • Remove the "Deprecated: InorbitConnectorConfig" section from docs/contents/specification/models.md and unused warnings/import references.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
inorbit_connector/models.py Removes InorbitConnectorConfig class; updates a docstring reference.
inorbit_connector/connector.py Drops isinstance deprecation branch and unused warnings import; updates __init__ docstring.
tests/test_models.py Removes TestInorbitConnectorConfig and TestInorbitConnectorConfigToFleetConfig; moves env-var tests into TestConnectorConfig.
tests/test_connector.py Migrates all connector tests to ConnectorConfig with explicit fleet=[RobotConfig(...)]; removes deprecation filter markers.
docs/contents/specification/models.md Removes documentation of deprecated InorbitConnectorConfig.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@b-Tomas b-Tomas self-assigned this May 19, 2026
@b-Tomas b-Tomas marked this pull request as ready for review May 19, 2026 23:13
@b-Tomas b-Tomas requested a review from miguelgarcia May 19, 2026 23:14
b-Tomas and others added 2 commits May 19, 2026 20:21
BREAKING CHANGE: InorbitConnectorConfig has been removed. Use
ConnectorConfig with a fleet list instead.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@b-Tomas b-Tomas force-pushed the breaking/remove-inorbit-connector-config branch from 8fb8994 to 0af406a Compare May 19, 2026 23:21
@b-Tomas b-Tomas merged commit 5371711 into next May 20, 2026
13 checks passed
@b-Tomas b-Tomas deleted the breaking/remove-inorbit-connector-config branch May 20, 2026 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants