Remove deprecated InorbitConnectorConfig class#69
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the deprecated InorbitConnectorConfig class and its to_fleet_config() helper from the models module, eliminating the corresponding isinstance branch and DeprecationWarning in Connector.__init__. Tests are migrated to instantiate ConnectorConfig directly with a fleet=[RobotConfig(...)] argument, and the related deprecation section in the docs is dropped.
Changes:
- Drop
InorbitConnectorConfigclass andto_fleet_config()frommodels.py; simplifyConnector.__init__to always callto_singular_config(). - Port all
test_connector.py/test_models.pycases (including env-var tests) toConnectorConfig+RobotConfig, removingfilterwarningsdecorators. - Remove the "Deprecated:
InorbitConnectorConfig" section fromdocs/contents/specification/models.mdand unusedwarnings/import references.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| inorbit_connector/models.py | Removes InorbitConnectorConfig class; updates a docstring reference. |
| inorbit_connector/connector.py | Drops isinstance deprecation branch and unused warnings import; updates __init__ docstring. |
| tests/test_models.py | Removes TestInorbitConnectorConfig and TestInorbitConnectorConfigToFleetConfig; moves env-var tests into TestConnectorConfig. |
| tests/test_connector.py | Migrates all connector tests to ConnectorConfig with explicit fleet=[RobotConfig(...)]; removes deprecation filter markers. |
| docs/contents/specification/models.md | Removes documentation of deprecated InorbitConnectorConfig. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
BREAKING CHANGE: InorbitConnectorConfig has been removed. Use ConnectorConfig with a fleet list instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
8fb8994 to
0af406a
Compare
miguelgarcia
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InorbitConnectorConfigclass frommodels.pyand theisinstanceguard + deprecation warning inConnector.__init__ConnectorConfigwithfleetparam; port env-var tests toTestConnectorConfigimport warningsfromconnector.py(no longer needed)docs/contents/specification/models.mdBreaking changes
InorbitConnectorConfighas been removed. Connectors that subclass or instantiate it must switch toConnectorConfigwith afleetlist:The
to_fleet_config()conversion method is also removed — callers already have the fleet structure.