Fix title leak for unauthorized viewers#12
Open
chruffins wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generateMetadatawas callingfindBySlugand using the doc's title unconditionally, which meant the browser tab /<title>tag would show a private doc's real title even when the page itself rendered a 404. An unauthorized viewer (or a bot crawling the page) could infer the existence and name of a private doc.Fix
The metadata function now runs the same authorization check (
canViewSession) thatViewerPageuses before revealing the doc's title. If no doc is found or the viewer isn't authorized, the title defaults to the neutral"justhtml.sh".