Skip to content

Fix title leak for unauthorized viewers #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chruffins wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −3
Open

Fix title leak for unauthorized viewers #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions app/d/[slug]/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,20 @@ type Props = {
searchParams: Promise<{ [k: string]: string | string[] | undefined }>;
};

export async function generateMetadata({ params }: Props): Promise<Metadata> {
export async function generateMetadata({ params, searchParams }: Props): Promise<Metadata> {
const { slug } = await params;
const doc = await findBySlug(slug);
const title = doc ? (doc.title || doc.slug) : "private";
return { title: `${title} — justhtml.sh` };
if (doc) {
const sp = await searchParams;
const rawToken = sp.viewtoken;
const viewtoken = Array.isArray(rawToken) ? (rawToken[0] ?? null) : (rawToken ?? null);
const req = await reconstructRequest();
const session = await getSession(req);
if (await canViewSession(doc, session, viewtoken)) {
return { title: `${doc.title || doc.slug} — justhtml.sh` };
}
}
return { title: "justhtml.sh" };
}

async function reconstructRequest(): Promise<Request> {
Expand Down
Loading