fix(client): respect trigger data in bulk feed status updates#1042
Draft
cjbell wants to merge 1 commit into
Draft
fix(client): respect trigger data in bulk feed status updates#1042cjbell wants to merge 1 commit into
cjbell wants to merge 1 commit into
Conversation
Co-authored-by: Chris Bell <chris@cjbell.co>
🦋 Changeset detectedLatest commit: c370c80 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Bundle ReportChanges will increase total bundle size by 104 bytes (0.02%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: @knocklabs/client-client-esmAssets Changed:
Files in
view changes for bundle: @knocklabs/client-client-cjsAssets Changed:
Files in
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1042 +/- ##
=======================================
Coverage 66.02% 66.03%
=======================================
Files 213 213
Lines 10500 10501 +1
Branches 1509 1509
=======================================
+ Hits 6933 6934 +1
Misses 3542 3542
Partials 25 25
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ensure bulk feed status operations (
markAllAsSeen,markAllAsRead, and archive variants) pass the feed'strigger_datafilter to the channel bulk status API. Trigger data is serialized consistently with feed fetch requests, preventing status updates from affecting notifications outside the visible filtered feed.Adds regression coverage for read and seen bulk operations and a patch changeset for
@knocklabs/client.Checklist
Linear Issue: KNO-14292