Skip to content

fix(client): respect trigger data in bulk feed status updates #1042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
cjbell wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −0
Draft

fix(client): respect trigger data in bulk feed status updates #1042

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/quiet-feeds-filter.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@knocklabs/client": patch
---

Scope bulk feed status updates to the feed's trigger data filters.
1 change: 1 addition & 0 deletions packages/client/src/clients/feed/feed.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -772,6 +772,7 @@ class Feed {
tenants: this.defaultOptions.tenant
? [this.defaultOptions.tenant]
: undefined,
trigger_data: getFormattedTriggerData(this.defaultOptions),
};

return await this.knock.messages.bulkUpdateAllStatusesInChannel({
Expand Down
1 change: 1 addition & 0 deletions packages/client/src/clients/messages/interfaces.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ export type BulkUpdateMessagesInChannelProperties = {
archived?: "exclude" | "include" | "only";
has_tenant?: boolean;
tenants?: string[];
trigger_data?: string;
};
};

Expand Down
7 changes: 7 additions & 0 deletions packages/client/test/clients/feed/feed.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,6 +429,7 @@ describe("Feed", () => {
engagement_status: undefined,
has_tenant: undefined,
tenants: undefined,
trigger_data: undefined,
},
});
expect(result).toEqual(bulkResponse);
Expand Down Expand Up @@ -466,6 +467,7 @@ describe("Feed", () => {
engagement_status: undefined,
has_tenant: undefined,
tenants: undefined,
trigger_data: undefined,
},
});
expect(result).toEqual(bulkResponse);
Expand Down Expand Up @@ -503,6 +505,7 @@ describe("Feed", () => {
engagement_status: undefined,
has_tenant: undefined,
tenants: undefined,
trigger_data: undefined,
},
});
expect(result).toEqual(bulkResponse);
Expand Down Expand Up @@ -1154,6 +1157,7 @@ describe("Feed", () => {
archived: "exclude",
has_tenant: true,
tenant: "tenant-123",
trigger_data: { type: "comment", priority: 1 },
},
undefined,
);
Expand All @@ -1169,6 +1173,7 @@ describe("Feed", () => {
archived: "exclude",
has_tenant: true,
tenants: ["tenant-123"],
trigger_data: '{"type":"comment","priority":1}',
},
});
} finally {
Expand All @@ -1191,6 +1196,7 @@ describe("Feed", () => {
{
status: "all", // Should not be included in options
archived: "include",
trigger_data: { type: "mention" },
},
undefined,
);
Expand All @@ -1206,6 +1212,7 @@ describe("Feed", () => {
archived: "include",
has_tenant: undefined,
tenants: undefined,
trigger_data: '{"type":"mention"}',
},
});
} finally {
Expand Down
Loading