[FIRRTL][InferResets] Add InstanceChoice support#9955
Merged
Conversation
uenoku
changed the title
uenoku
commented
Mar 16, 2026
uenoku
force-pushed
the
dev/hidetou/infer-reset-choice
branch
3 times, most recently
from
f1d5f68 to
aa5460a
Compare
uenoku
changed the title
seldridge
approved these changes
Mar 19, 2026
Member
seldridge
left a comment
seldridge
left a comment
There was a problem hiding this comment.
Generally LTGM and mostly nits. Two questions:
- Any way to remove the template? That always feels a bit hacky or it indicates that the IR could be improved or generalized.
- Tests of errors should be added.
Comment on lines
+920
to
+921
| if (!node || !node->getModule()) | ||
| return; |
Member
There was a problem hiding this comment.
I forget. What condition is this trying to catch?
Member
Author
There was a problem hiding this comment.
It's redundant and deleted. Thank you for pointing out.
Member
There was a problem hiding this comment.
Can the PR include an error test?
This commit adds comprehensive support for InstanceChoiceOp in the InferResets pass, handling all referenced modules (default target and all alternatives).
uenoku
force-pushed
the
dev/hidetou/infer-reset-choice
branch
from
aa5460a to
39130ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend the InferResets pass to handle InstanceChoiceOp alongside
InstanceOp. This enables reset type inference to work correctly
across instance_choice operations by tracing resets through all
possible target modules. The implementation uses InstanceOpInterface
and extracts common logic into a template helper function.
AI-assited-by: Sonnet 4.5