[lldb] Add additional logging to wait_for_file_on_target#186915
Open
[lldb] Add additional logging to wait_for_file_on_target#186915
Conversation
Occasionally wait_for_file_on_target will time out on the Green Dragon bots and we're not sure why. I'm adding this logging in an attempt to get more clues as to what's happening when it fails.
Member
|
@llvm/pr-subscribers-lldb Author: Alex Langford (bulbazord) ChangesOccasionally wait_for_file_on_target will time out on the Green Dragon bots and we're not sure why. I'm adding this logging in an attempt to get more clues as to what's happening when it fails. Full diff: https://github.com/llvm/llvm-project/pull/186915.diff 1 Files Affected:
diff --git a/lldb/packages/Python/lldbsuite/test/lldbutil.py b/lldb/packages/Python/lldbsuite/test/lldbutil.py
index e3f64fb9782a4..7f7cdde561702 100644
--- a/lldb/packages/Python/lldbsuite/test/lldbutil.py
+++ b/lldb/packages/Python/lldbsuite/test/lldbutil.py
@@ -1687,7 +1687,14 @@ def read_file_from_process_wd(test, name):
def wait_for_file_on_target(testcase, file_path, max_attempts=6):
for i in range(max_attempts):
- err, retcode, msg = testcase.run_platform_command("ls %s" % file_path)
+ command = f"ls {file_path}"
+ err, retcode, msg = testcase.run_platform_command(command)
+ if testcase.TraceOn():
+ testcase.trace(f"Ran command: {command}")
+ testcase.trace(f"Retcode: {retcode}")
+ testcase.trace(f"Output: {msg}")
+ testcase.trace(f"Error: {err.description}")
+
if err.Success() and retcode == 0:
break
if i < max_attempts:
|
JDevlieghere
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Occasionally wait_for_file_on_target will time out on the Green Dragon bots and we're not sure why. I'm adding this logging in an attempt to get more clues as to what's happening when it fails.