fix: upgrade Furo to 2025.12.19 to fix right panel highlight offset (#7019)#9074
Open
rafaumeu wants to merge 2 commits into
Open
fix: upgrade Furo to 2025.12.19 to fix right panel highlight offset (#7019)#9074rafaumeu wants to merge 2 commits into
rafaumeu wants to merge 2 commits into
Conversation
…attermost#7019) The fixed notification banner breaks the right sidebar's scrollspy section detection because it doesn't account for sticky elements above the header. Furo PR mattermost#664 (released in 2025.07.19) fixes this by including header.top in the offset calculation. Upgrading from 2024.8.6 to 2025.12.19 includes this fix plus Sphinx 9 support and other improvements.
Contributor
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ChangesFuro Dependency Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades Furo theme from 2024.8.6 to 2025.12.19 to fix the right panel (table of contents) highlight offset issue where the active section was highlighted one index previous to the actual current section.
Root Cause
Furo's scrollspy logic for the right sidebar ("On this page") did not account for sticky/fixed elements above the main header (like custom notification banners or headers). This caused the active section detection to be off by one.
Fix
Furo PR #664 (merged in 2024.08.06) fixed this by including
in the scroll offset calculation, making the TOC highlight resilient to sticky elements above the header.Testing
Fixes #7019