chore: normalize CRLF to LF in bug reports#26
Merged
ako merged 1 commit intomendixlabs:mainfrom Mar 25, 2026
Merged
Conversation
ako
approved these changes
Mar 25, 2026
Collaborator
ako
left a comment
ako
left a comment
There was a problem hiding this comment.
Code Review: chore: normalize CRLF to LF in bug reports
Single commit, 3 files under docs/12-bug-reports/, pure CRLF→LF line ending normalization. No content changes. Looks good.
One note: The PR description mentions setting core.autocrlf=input to prevent future CRLF pollution, but there's no .gitattributes change in the diff. That git config setting is local to the contributor's machine and won't carry over to other clones. Consider adding a .gitattributes file with * text=auto as a follow-up to enforce LF at the repo level.
🤖 Generated with Claude Code
3 tasks
ako
pushed a commit
that referenced
this pull request
Mar 26, 2026
Date attributes are stored as DomainModels$DateTimeAttributeType with LocalizeDate=false in BSON. Added DateAttributeType (domain model) and DateType (microflows) structs. Parser now distinguishes Date (LocalizeDate=false) from DateTime (LocalizeDate=true). Updated all type switches in executor, formatters, writers, and catalog. Also fixed Long type mapping in cmd_dbconnection.go (DataTypes$LongType). Fixes #26
ako
pushed a commit
that referenced
this pull request
Mar 26, 2026
26 unit tests covering: - #18: loopEndKeyword (WHILE vs LOOP), WHILE loop header formatting - #19: Long type mapping (convertASTToMicroflowDataType, GetTypeName) - #25: DESCRIBE CONSTANT COMMENT output, escaping, absence - #26: Date vs DateTime type mapping and constant formatting - #27: isQualifiedEnumLiteral, enum RETURN without $ prefix - #28: inline if-then-else parsing and expressionToString serialization - #23: deriveColumnName from attribute, caption, fallback, special chars Issue #20 (XPath tokens) already covered by bugfix_test.go.
ako
added a commit
that referenced
this pull request
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/12-bug-reports/core.autocrlf=inputto prevent future CRLF pollutionTest plan