[SPIR-V] Add error for casting from vector to scalar#4688
Closed
cassiebeckley wants to merge 1 commit into
Closed
Conversation
vettoreldaniele
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, but I believe DXIL only outputs a warning and extends the variable with zero values.
Do we want to match DXIL's behavior here?
I also get two errors from this - is it intended?
../tools/clang/test/CodeGenSPIRV/cast.scalar-to-vec.implicit.hlsl:15:7: error: casting from 'float' to 'float3' unsupported
foo(bar);
^
../tools/clang/test/CodeGenSPIRV/cast.scalar-to-vec.implicit.hlsl:15:7: error: casting from 'float3' to 'float' unsupported
vettoreldaniele
suggested changes
Sep 27, 2022
Collaborator
There was a problem hiding this comment.
Also, I just noticed this fix only applies to float. But this behavior seems to be independent of type (see https://shader-playground.timjones.io/f1b2e245672750fae10053e504f16e22 for an example with int).
Collaborator
|
#5249 will make this obsolete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4640