Skip to content

Skip static cbuffer variables in explicit layout indexing#8538

Open
fall2019 wants to merge 1 commit into
microsoft:mainfrom
fall2019:fix_spirv_static_cbuffer_index
Open

Skip static cbuffer variables in explicit layout indexing#8538
fall2019 wants to merge 1 commit into
microsoft:mainfrom
fall2019:fix_spirv_static_cbuffer_index

Conversation

@fall2019

Copy link
Copy Markdown

This fixes invalid SPIR-V generation when a cbuffer contains interleaved static const declarations.

Fixes #8537

@fall2019

Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree

@hekota hekota left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fall2019

Copy link
Copy Markdown
Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Commenter does not have sufficient privileges for PR 8538 in repo microsoft/DirectXShaderCompiler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: New

Development

Successfully merging this pull request may close these issues.

[SPIR-V] Static const declarations inside cbuffer can corrupt member indices and generate invalid OpAccessChain.

2 participants