Feature/ssl certbot for new URL#7
Conversation
- Add certbot sidecar container with auto-renewal to docker-compose.prod.yml - Update nginx to redirect HTTP to HTTPS with ACME challenge support - Expose ports 80 and 443, update CORS and APP_URL to https://micss-lab.be - Health check workflow now uses vars.APP_URL instead of hardcoded domain - Add init-letsencrypt.sh bootstrap script for first-time cert setup
There was a problem hiding this comment.
Pull request overview
Updates production/public URL references to point to the new micss-lab.be domain.
Changes:
- Update README live demo link to the new domain.
- Update production Docker Compose backend
CORS_ORIGINand defaultAPP_URL. - Update the scheduled GitHub Actions health check to use an Actions variable for the base URL.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| README.md | Updates the published “Live demo” URL. |
| docker-compose.prod.yml | Updates backend env defaults/origins for the new production URL. |
| .github/workflows/health-check.yml | Switches health check target from a hardcoded URL to ${{ vars.APP_URL }}. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| if response=$(curl -sf --max-time 30 https://spatialdsl.tmusml.cloud/api/health); then | ||
| if response=$(curl -sf --max-time 30 ${{ vars.APP_URL }}/api/health); then | ||
| echo "$response" |
There was a problem hiding this comment.
The workflow now depends on the repository/org Actions variable APP_URL (vars.APP_URL). If it isn’t defined, this expression resolves to an empty string and curl will run against /api/health, causing the job to fail with an invalid/missing URL. Consider providing a safe default in the expression (or setting an env: APP_URL: ${{ vars.APP_URL || 'https://micss-lab.be' }} and using $APP_URL), and quote the URL to avoid shell word-splitting.
| DATABASE_URL: postgresql://${POSTGRES_USER}:${POSTGRES_PASSWORD}@db:5432/${POSTGRES_DB}?schema=public | ||
| PORT: 3001 | ||
| NODE_ENV: production | ||
| CORS_ORIGIN: https://spatialdsl.tmusml.cloud | ||
| CORS_ORIGIN: https://micss-lab.be | ||
| MAX_FILE_SIZE: 52428800 |
There was a problem hiding this comment.
PR title/description mention "ssl certbot", but the changes in this PR only update the public URL references (README, compose env vars, health check). Either update the PR title/description to match the actual scope, or include the missing certbot-related configuration changes if they were intended.
Feature/ssl certbot for new URL